fix: make "set as canonical" findable in merge reviews - #386
Merged
Conversation
The control that changes which node survives a merge was an unlabeled
16px circle whose inner dot had no background colour — it rendered as an
empty ring with a border/60 outline, indistinguishable from a bullet on
a dark row, with the action named only in a title tooltip. The backend
has accepted an override_payload {from, to} on approve for a while, so
the capability was wired end to end but effectively undiscoverable.
Replace the dot with a labelled pill (○ MAKE CANONICAL): muted at rest,
primary border/tint/text on hover, plus cursor-pointer and a focus ring
so it is reachable by keyboard.
Also surface when the operator has edited the proposal. approve_review
dispatches the override but never persists it on the Review node, so
after approval nothing records that the direction was flipped — show an
inline note naming the new canonical before the merge is committed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The control that changes which node survives a merge was an unlabeled 16px circle whose inner dot had no background colour — it rendered as an empty ring with a border/60 outline, indistinguishable from a bullet on a dark row, with the action named only in a title tooltip. The backend has accepted an override_payload {from, to} on approve for a while, so the capability was wired end to end but effectively undiscoverable.
Replace the dot with a labelled pill (○ MAKE CANONICAL): muted at rest, primary border/tint/text on hover, plus cursor-pointer and a focus ring so it is reachable by keyboard.
Also surface when the operator has edited the proposal. approve_review dispatches the override but never persists it on the Review node, so after approval nothing records that the direction was flipped — show an inline note naming the new canonical before the merge is committed.