feat: show the parked subgraph in the promotion dialog - #385
Merged
Conversation
The dialog showed aggregate property counts only, so an admin approving a schema type could not see which nodes it would promote, nor the relationships between them. Add a subgraph panel above the property table listing the nodes by name and the relationships joining them. Edges whose other end is parked under a different type are rendered greyed and labelled "still parked" — those are not promoted by this approval, and the resulting node comes out disconnected from that side until the other type is approved too. That distinction is the reason the panel exists; a plain edge list would imply the whole structure survives. Also surface edge failures after approval. Previously the row spoke up only when ENTRIES failed to promote, so a perfect node promotion with broken relationships read as clean success. edges.pending is deliberately not treated as a problem — it is the expected steady state for a subgraph approved one type at a time.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The dialog showed aggregate property counts only, so an admin approving a schema type could not see which nodes it would promote, nor the relationships between them.
Add a subgraph panel above the property table listing the nodes by name and the relationships joining them. Edges whose other end is parked under a different type are rendered greyed and labelled "still parked" — those are not promoted by this approval, and the resulting node comes out disconnected from that side until the other type is approved too. That distinction is the reason the panel exists; a plain edge list would imply the whole structure survives.
Also surface edge failures after approval. Previously the row spoke up only when ENTRIES failed to promote, so a perfect node promotion with broken relationships read as clean success. edges.pending is deliberately not treated as a problem — it is the expected steady state for a subgraph approved one type at a time.