Skip to content

ROX-34386: Split main and release pipeline to remove image expire#169

Merged
mtodor merged 1 commit into
release-0.2from
mtodor/ROX-34386-conforma-fix-1
Jul 23, 2026
Merged

ROX-34386: Split main and release pipeline to remove image expire#169
mtodor merged 1 commit into
release-0.2from
mtodor/ROX-34386-conforma-fix-1

Conversation

@mtodor

@mtodor mtodor commented Jul 23, 2026

Copy link
Copy Markdown
Collaborator

Description

This PR splits release and main branch on push pipeline.

This solution keeps base component pipeline simple and without any custom logic.

Validation

  • Check push Konflux pipeline run
  • Trigger run with label - check that release pipeline is used
  • Check that image build with release pipeline triggered by label does not contain expire label
  • Check that Snyk runs (this was one of conforma failures and secret is added)

@mtodor
mtodor requested a review from janisz as a code owner July 23, 2026 11:06
@coderabbitai

coderabbitai Bot commented Jul 23, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

📝 Walkthrough

Walkthrough

Tekton configurations update pull request trigger formatting and parameter typing, narrow main-branch triggers, and add a release pipeline with event conditions, build settings, timeouts, service-account wiring, and git authentication.

Changes

Tekton trigger routing

Layer / File(s) Summary
Pull request trigger parameter contract
.tekton/acs-mcp-server-pull-request.yaml
Pull request CEL presence checks are reformatted, and image-expires-after is changed to the string value "5d".
Main-branch trigger routing
.tekton/acs-mcp-server-push-main.yaml
Triggers are restricted to main pushes and eligible labeled pull requests; the PipelineRun name becomes acs-mcp-server-on-push-main.
Release pipeline definition
.tekton/acs-mcp-server-push-release.yaml
Adds release event conditions, build parameters, multi-architecture targets, execution settings, timeouts, and a git-auth workspace for the release PipelineRun.

Estimated code review effort: 2 (Simple) | ~15 minutes

Suggested reviewers: janisz

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Title check ✅ Passed The title accurately summarizes splitting main and release pipelines and removing image expiration.
Description check ✅ Passed The description matches the change by explaining the main/release pipeline split and related validation.
✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch mtodor/ROX-34386-conforma-fix-1

Comment @coderabbitai help to get the list of available commands.

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In @.tekton/acs-mcp-server-push-release.yaml:
- Around line 40-41: Replace the hardcoded value of the output-image-repo
parameter in the PipelineRun with the approved destination repository parameter
or bundle-provided configuration, while preserving the existing parameter name
and image-output flow.
🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: Repository YAML (base), Central YAML (inherited), Organization UI (inherited)

Review profile: ASSERTIVE

Plan: Enterprise

Run ID: 43700057-ecd4-4774-bfec-06fab0afbb70

📥 Commits

Reviewing files that changed from the base of the PR and between 3dd6a3a and 1900fc0.

📒 Files selected for processing (3)
  • .tekton/acs-mcp-server-pull-request.yaml
  • .tekton/acs-mcp-server-push-main.yaml
  • .tekton/acs-mcp-server-push-release.yaml

Comment thread .tekton/acs-mcp-server-push-release.yaml
@github-actions

Copy link
Copy Markdown

E2E Test Results

Commit: 1900fc0
Workflow Run: View Details
Artifacts: Download test results & logs

=== Evaluation Summary ===

  ✓ cve-clusters-general (assertions: 3/3)
  ✓ cve-cluster-does-exist (assertions: 3/3)
  ✓ list-clusters (assertions: 3/3)
  ✓ cve-cluster-does-not-exist (assertions: 3/3)
  ✓ cve-detected-workloads (assertions: 3/3)
  ✓ rhsa-not-supported (assertions: 2/2)
  ✓ cve-detected-clusters (assertions: 3/3)
  ✗ cve-nonexistent (assertions: 2/3)
      one or more verification steps failed
      - MaxToolCalls: Too many tool calls: expected <= 5, got 6
  ✓ cve-log4shell (assertions: 3/3)
  ✓ cve-cluster-list (assertions: 3/3)
  ✓ cve-multiple (assertions: 3/3)

Tasks:      10/11 passed (90.91%)
Assertions: 31/32 passed (96.88%)
Tokens:     ~51325 (estimate - excludes system prompt & cache)
MCP schemas: ~12562 (included in token total)
Agent used tokens:
  Input:  14070 tokens
  Output: 19847 tokens
Judge used tokens:
  Input:  42712 tokens
  Output: 37491 tokens

@codecov-commenter

codecov-commenter commented Jul 23, 2026

Copy link
Copy Markdown

❌ 2 Tests Failed:

Tests completed Failed Passed Skipped
380 2 378 12
View the full list of 2 ❄️ flaky test(s)
::policy 1

Flake rate in main: 100.00% (Passed 0 times, Failed 66 times)

Stack Traces | 0s run time
- test violation 1
- test violation 2
- test violation 3
::policy 4

Flake rate in main: 100.00% (Passed 0 times, Failed 66 times)

Stack Traces | 0s run time
- testing multiple alert violation messages 1
- testing multiple alert violation messages 2
- testing multiple alert violation messages 3

To view more test analytics, go to the Test Analytics Dashboard
📋 Got 3 mins? Take this short survey to help us improve Test Analytics.

@mtodor
mtodor merged commit 7da62d1 into release-0.2 Jul 23, 2026
11 checks passed
@mtodor
mtodor deleted the mtodor/ROX-34386-conforma-fix-1 branch July 23, 2026 12:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants