feat: support setting metadata.annotations - #281
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yml Review profile: CHILL Plan: Enterprise Run ID: 📒 Files selected for processing (1)
Included review availability: Your plan provides up to 12 included reviews per hour; 10 remain after this review. 📝 WalkthroughWalkthroughThe change adds optional metadata annotations to Central and SecuredCluster configuration. Their custom-resource builders merge these annotations into resource metadata and report annotation merge errors. ChangesMetadata annotations
Estimated code review effort: 2 (Simple) | ~10 minutes Merge Risk: ⚪ Minimal · up to This change adds optional metadata annotations to Central and SecuredCluster custom resources without introducing a general metadata override. No current merge-readiness risk remains. Suggested reviewers: 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Comment |
| DeployTimeout time.Duration `yaml:"deployTimeout,omitempty"` | ||
| PortForwarding *bool `yaml:"portForwarding,omitempty"` | ||
| EarlyReadiness *bool `yaml:"earlyReadiness,omitempty"` | ||
| MetadataAnnotations map[string]string `yaml:"metadataAnnotations,omitempty"` |
There was a problem hiding this comment.
wondering about potential related use-cases in the future -- should we maybe
make this a nested central.metadata.annotations?
There was a problem hiding this comment.
It crossed my mind, but I'm wondering if existence of central.metadata might make people incorrectly think anything in there is settable? 🤔
There was a problem hiding this comment.
Not saying that we have to do it this way, but I believe that this is something that should be coverable by docs and if people make wrong assumptions based on that... well. 🤷
Needed for https://redhat.atlassian.net/browse/ROX-36583 which sets
platform.stackrox.io/managed-services: true.I only added annotations for now, as overriding all of
metadatacould lead to "creative" but fragile uses.Tested in another PR.
Summary by CodeRabbit