test(episodes): characterize mixed admission boundaries - #127
Merged
Conversation
Owner
Author
|
Final diff review after CI: no findings.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
[18x pass, 1x fail]Why
Candidate-v2 exposes one segment-level
admittedvalue plus pair-level contrast evidence. The missing mixed case left the aggregate meaning ambiguous: one passing boundary must not make an otherwise mixed selection admissible, while one failing boundary must not erase the passing local evidence.How to validate
python -m unittest discover -s tests -p 'test_episode*.py'— 44 passedpython -m ruff check .— passedctest --test-dir build -C Debug --output-on-failure— 7/7 passedgit diff --check origin/main...HEAD— passedgitleaks git --log-opts="origin/main..HEAD" --redact --no-banner— no leaksall(...)toany(...)makes the new focused test fail withTrue is not falseRisk / rollout notes
admittedmeans the complete v1 selection may be adopted unchanged; it is not a per-candidate validity verdict.loglens.report.v3behavior changes.