feat(research): evaluate minimum-span threshold cores - #125
Merged
Conversation
Owner
Author
|
Final diff review after CI:
Post-CI evidence: 11/11 GitHub checks passed; final diff is 3 files with behavior/test/docs commit separation; no review or bot comments are outstanding; origin/main remains f780843. The planned stopping rule is met without a parameter sweep. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Why
Raw mean-gap contrast over maximal selected windows is coupled to coverage padding. This slice tests the smallest alternative evidence abstraction without changing candidate-v1 selection or production behavior.
Design decision
Use the shortest contiguous sequence of exactly
thresholdevents inside each selected maximal window as candidate-v2 density evidence. Equal-span cores use the chronological key. Events excluded from a core still count toward bridge density.This is accepted only for the three bounded controls. It is not wired into the candidate evaluator, detector, CLI, report, or schema.
How to validate
Expected evidence:
Main risk
The abstraction may overfit the three synthetic controls, and the existing 2x contrast remains uncalibrated. Minimum-span evidence may also ignore operationally relevant events that remain part of maximal candidate coverage.
Compatibility impact
None for supported behavior.
Detector::analyze(), CLI output,loglens.report.v3, candidate-v1 selection, fixture schema, and evaluator materialization are unchanged. The new functions remain in the bounded research helper.Rollback path
Revert the three semantic commits in reverse order:
docs(episodes): accept threshold core evidencetest(research): gate threshold core contrastfeat(research): derive threshold-sized coresStopping rule and nonclaims
The planned padding, 18x positive, and 1x negative controls all distinguish correctly, so this slice stops without a quantile, trimmed-gap, cadence, position, or ratio sweep. It does not calibrate production thresholds, estimate false-positive rates, or authorize candidate-v2 materialization.