test(research): add isolated burst compatibility control - #118
Conversation
|
Post-CI final diff review completed on head
The PR remains draft because it contains 600 evidence-heavy additions and crosses the report/schema research boundary. The delayed review gate still applies; this initial green run is not merge authorization by itself. |
|
Delayed diff review completed after 9.88 hours on unchanged head
Fresh exact-head validation:
Design decision: retain isolated bursts as a null control that must preserve the replayed v0.6 identities and one-time evidence partition. |
Summary
isolated_dense_burstsfixture and a replayed v0.6 baseline as a null control.Why
The candidate already recovers two dense peaks connected by sparse background. It must also preserve the v0.6 result when two bursts are already separated correctly. This slice tests that rejection boundary without adding another threshold or tie-break enumeration.
Design decision
Treat isolated bursts as a null control: with threshold 5, an inclusive 600-second window, and a 1,080-second inter-segment gap, both v0.6 and the candidate must emit the same two deterministic findings and consume every event exactly once.
Main risk
This is one bounded synthetic control. It does not establish behavior for maximal-window ties, shared evidence, background calibration, or production-scale complexity.
Compatibility impact
None for the runtime, CLI, report schema, or stable release.
src/is unchanged; the diff adds research fixtures, regression coverage, and ADR evidence only.Rollback path
Revert the three semantic commits or close the PR. There is no migration, persisted state, release artifact, or runtime toggle to unwind.
Validation
python -m pip install -r requirements-test.txtpython -m ruff check scripts testspython -B -m unittest discover -s tests -p "test_episode_candidate*.py" -v— 25/25 passed--checkreplay for both committed fixtures — passedcmake --preset ci-releasecmake --build --preset ci-release— MSVC warnings-as-errors build passedctest --preset ci-release— 7/7 passedgit diff --check origin/main...HEAD— passedgitleaks git --no-banner --redact --log-opts "origin/main..HEAD"— no leaks203.0.113.78; no local paths or secret assignmentsReview gate
Draft because the evidence-heavy diff has 600 additions and changes a report/schema research boundary. Keep it open for the required delayed diff review; do not merge from this initial validation alone.