test(research): harden candidate oracle validation - #116
Merged
Conversation
Owner
Author
|
Post-CI diff review completed at
Evidence: 14/14 candidate tests with no schema skip, sanitized malformed-input regression, 7/7 CTest, CI YAML parse, This PR remains draft until #115 completes its delayed review; then retarget it to |
This was referenced Aug 25, 2026
…nto stacknil/v07-candidate-oracle-validation
…nto stacknil/v07-candidate-oracle-validation
…e-oracle-validation
Owner
Author
|
Final current-head review for
Fresh evidence on this exact head:
No review or bot comment requires action. |
stacknil
marked this pull request as ready for review
August 27, 2026 03:20
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary - install and pin Draft 2020-12 JSON Schema validation for the research fixture gate - run the complete baseline/core/oracle/negative-validation suite inside CTest and cross-platform CI - preserve sanitized CLI failure behavior while adapting validation to #117's explicit baseline context ## Why #115 materializes the bounded oracle. This stacked PR makes schema and malformed-input/cross-reference checks mandatory in CI rather than relying on a developer's optional environment. It remains separate so dependency/CI policy can be reviewed and rolled back independently. ## How to validate
text python -m pip install -r requirements-test.txt python -m ruff check scripts/episode_baseline_contract.py scripts/episode_candidate_core.py scripts/evaluate_episode_candidate.py tests/test_episode_candidate_baseline_contract.py tests/test_episode_candidate_core.py tests/test_episode_candidate.py tests/test_episode_candidate_validation.py python -B -m unittest discover -s tests -p "test_episode_candidate*.py" -v cmake -S . -B build -D CMAKE_BUILD_TYPE=Release -D BUILD_TESTING=ON -D LOGLENS_WARNINGS_AS_ERRORS=ON cmake --build build --config Release ctest --test-dir build --build-config Release --output-on-failureExpected: Ruff passes, 22 research tests pass without schema skips, and all 7 CTest entries pass. ## Design decision Keepjsonschema==4.26.0test-only. The evaluator and baseline contract remain standard-library tools; CI owns schema availability. Semantic validation requires fixture, baseline, and oracle together, while schema validation covers the serialized shape. ## Main risk A pinned test dependency adds update maintenance. The pin is isolated torequirements-test.txt; removing this PR restores the prior dependency-free runtime and optional schema check. ## Compatibility impact No runtime, detector, report, CLI, configuration, or release behavior change. The workflow adds one test-only installation step. ## Rollback path Revert the two validation commits plus the small compatibility-test commit. #117 and #115 remain independently usable without the CI dependency. ## Review policyMerged after #117 and #115, retargeting to
main, fresh exact-head checks (11/11), a 22-test run with no schema skip, and final review of the three-file CI/validation diff.