Report unsupported external auth types - #6242
Open
3nesdeniz wants to merge 1 commit into
Open
Conversation
Signed-off-by: Enes Deniz <142517728+3nesdeniz@users.noreply.github.com>
3nesdeniz
marked this pull request as ready for review
August 8, 2026 11:09
3nesdeniz
requested review from
ChrisJBurns,
JAORMX,
amirejaz,
blkt,
jerm-dro,
jhrozek,
rdimitrov,
reyortiz3 and
tgrunnagle
as code owners
August 8, 2026 11:09
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
MCPServer,MCPRemoteProxy,VirtualMCPServer, andMCPServerEntry, and surface unsupported or source-invalid configurations through explicit status conditions.Fixes #5930
Type of change
Test plan
task test)task test-e2e)task lint-fix)Verified after rebasing onto the current
upstream/main:task operator-test(race detector enabled)task operator-test-integration(all 11 suites passed)task testcoverage for converter validation, auth precedence, and invalid-source watcher removal (race detector enabled)task operator-generate,task operator-manifests, andtask crdref-gen; a second generation pass produced no diffgit diff --checkAPI Compatibility
v1beta1API, OR theapi-break-allowedlabel is applied and the migration guidance is described above.Changes
cmd/thv-operator/pkg/externalauthsupportpkg/vmcpdiscovery and watcher pathsDoes this introduce a user-facing change?
Yes. Unsupported external-auth combinations now produce an
ExternalAuthConfigValidated=Falsecondition with a specific reason and message. Virtual-MCP backends whose outgoing auth cannot be resolved remain excluded instead of being routed without the intended auth, while unaffected backends continue to operate.Special notes for reviewers
The diff exceeds 1,000 lines because it includes 2,328 added lines of regression/integration tests and 396 added lines of generated CRD/reference artifacts; the production-code portion is 836 added lines. The change remains one cohesive compatibility and fail-closed behavior update for the external-auth consumption paths covered by #5930.
The full root
task testwas also run. Its remaining failures require a local Docker/Colima runtime for API and Envoy integration cases; all affected packages pass through the focused race-enabledtask testcommand above.task lintreports only the existingG115warning incmd/thv/app/upgrade.go:204, which is unchanged fromupstream/main.The most security-sensitive paths are the dynamic backend watcher precedence and deny-list handling, including late-joining backends after default-auth resolution fails.