fix(ci): remove duplicate cache key in releaser workflow - #445
Merged
Conversation
#444 switched every setup-go step from go-version-file to go-version: 'stable' + cache: true. releaser.yml already had cache: true, so it ended up with the key twice: with: go-version: 'stable' cache: true cache: true GitHub rejects the whole file as an invalid workflow, which is why the push to main produced a jobless failing "Release" run. The next tag push would not have released anything. This slipped through because releaser.yml only triggers on tag pushes, so no pull request check ever parsed it, and PyYAML accepts duplicate keys silently (last one wins). actionlint does catch it: releaser.yml:72:11: key "cache" is duplicated in "with" section [syntax-check] Also collapses the stray double blank lines the same rewrite left in test.yml and codeql.yml. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
stacklokbot
approved these changes
Aug 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hotfix —
maincurrently has an invalid workflow file and the release pipeline is broken.What happened
#444 switched every
setup-gostep fromgo-version-file: ./go.modtogo-version: 'stable'+cache: true.releaser.ymlalready hadcache: true, so it came out with the key twice:GitHub rejects the entire file as an invalid workflow. That's the jobless failing
Releaserun on the merge commit (run 31756816798) — 0 jobs, immediate failure, workflow shown by file path rather than by itsname:. The next tag push would not have released anything.Why nothing caught it
Three independent gaps lined up:
releaser.ymlonly triggers onpush: tags, so no PR check ever parsed it. All 9 checks on chore(deps): batch all pending dependency updates and fix CI #444 were green and stayed green — they simply never looked at this file.yaml.safe_loadreported the file as fine, and printed a collapsed{'go-version': 'stable', 'cache': True}.grep -A3spot-check window stopped exactly one line short of the secondcache: true.actionlintcatches it precisely:This change
cache: truefromreleaser.ymltest.ymlandcodeql.yml(cosmetic, same root cause)Deletions only — 7 lines, no behaviour change beyond making the file valid again.
Verification
actionlinton all 5 workflowsrun:blocks)actionlinton the currentmainversionFollow-up worth doing
The real gap is that
releaser.ymlis never validated on PRs. Adding anactionlintstep to thelintjob would parse every workflow file on every PR and would have caught this before merge. Happy to send that as a separate PR — left out here to keep the hotfix trivially reviewable.🤖 Generated with Claude Code