Repository navigation
Conversation
Contributor
|
Hi @mittalpk, |
Author
|
Good point, I couldn't run the ACC tests (no STACKIT account) and missed that the pattern matches the API's canonical duration format, so |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
relates to #1847
The ALB health check
interval,interval_jitterandtimeoutvalidators used^[0-9]{1,3}s|[0-9]{1,3}\.(?:[0-9]{2}[1-9]|[0-9][1-9][0-9]|[1-9][0-9]{2})s$. Because the two alternatives were not grouped,^anchored only the first and$only the second, so values like5sGARBAGEorGARBAGE1.500spassed validation and only failed at the API.All three now share one grouped pattern with the same accepted set: whole seconds, or exactly three decimals that are not all zero. That is the form the API returns durations in, so values like
0.1sor1.000sstay rejected to avoid state drift.Checklist
make fmtexamples/directory)make generate-docs(will be checked by CI)make test(will be checked by CI)make lint(will be checked by CI)