Skip to content

feat(postgresflex): add instance deletion protection - #1813

Open
MarcAd1234 wants to merge 1 commit into
stackitcloud:mainfrom
MarcAd1234:feat/postgresflex-instance-deletion-protection
Open

MarcAd1234 wants to merge 1 commit into
stackitcloud:mainfrom
MarcAd1234:feat/postgresflex-instance-deletion-protection

Conversation

@MarcAd1234

Copy link
Copy Markdown

Description

Adds deletion_protection to stackit_postgresflex_instance (optional) and the data source .

  • The create API doesn't accept the flag, so protection is enabled via POST .../protections once the instance is ready.
  • terraform destroy fails early with a clear message if the instance is protected.
  • If the attribute isn't set, the current value from the API is kept, so existing configs show no diff after upgrading

relates to #1800

FYI: TestAccPostgresFlexInstanceMax passes create, data source and import, but the update step fails on 5 pre-existing checks so this seems to be an issue in the test case rather than in this change.

Checklist

  • Issue was linked above
  • Code format was applied: make fmt
  • Examples were added / adjusted (see examples/ directory)
  • Docs are up-to-date: make generate-docs (will be checked by CI)
  • Unit tests got implemented or updated
  • Acceptance tests got implemented or updated
  • Unit tests are passing: make test (will be checked by CI)
  • No linter issues: make lint (will be checked by CI)

@github-actions

Copy link
Copy Markdown

This PR was marked as stale after 14 days of inactivity and will be closed after another 14 days of further inactivity. If this PR should be kept open, just add a comment, remove the stale label or push new commits to it.

@github-actions github-actions Bot added the Stale PR is marked as stale due to inactivity. label Oct 27, 2026
@HartmannVolker

Copy link
Copy Markdown

What is blocking this PR?

@MarcAd1234
MarcAd1234 force-pushed the feat/postgresflex-instance-deletion-protection branch from 06412d5 to bf659a8 Compare October 29, 2026 15:30
@MarcAd1234

Copy link
Copy Markdown
Author

Rebased onto current main;
still waiting for review

@github-actions github-actions Bot removed the Stale PR is marked as stale due to inactivity. label Oct 30, 2026

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants