Skip to content

Remove deprecated empty provider "time" block #59

Closed

Description

@madejusz

The provider "time" {} block in src/providers.tf (line 69) is a deprecated proxy provider configuration.

The time provider is already properly declared in required_providers in terraform.tf, which is sufficient. The empty block triggers a deprecation warning during terraform init.

Fix available here: madejusz@c3c3b81

btw. I'm currently working on a sovereign cloud deployment using this landing zone and will likely encounter more issues like this one. Would it be possible to grant contributor access so I can submit PRs directly instead of going through issues?

Activity

  1. mahauber commented on Aug 27, 2026

    @mahauber
    Collaborator

    Hi @madejusz, thanks for opening the issue.

    The Redundant empty provider block warning only applies to child modules: it flags proxy provider configurations, i.e. an empty provider "x" {} in a module that expects a config from its caller via providers = {}. src/ is the root module, so it's exempt. Verified with OpenTofu 1.12.5: the block warns in a child module, and gives a clean Success! The configuration is valid. in the root. src/providers.tf:69 emits nothing at init, validate, or plan.

    It is redundant though, since the time provider takes no configuration arguments, the pin in terraform.tf is what matters, and the default config is created implicitly either way. So removing it is safe cleanup. Happy to merge madejusz/stackit-landing-zone@c3c3b81 as a PR, just reworded so it doesn't claim a deprecation warning, e.g. chore: drop redundant empty time provider block.

    On access: fork-and-PR is the standard path here and needs no write access. You can open PRs from your fork and we'll review them.

  2. added
    area:acceleratorAccelerator Terraform/OpenTofu roots, modules and examples
    priority:p3Lower urgency or optional extension
    effort:sSmall bounded change including regression tests and documentation
    needs-investigationValidate API/provider behavior or product contract before implementation
    on Oct 1, 2026
  3. lweberru commented on Oct 10, 2026

    @lweberru
    Collaborator

    Local qualification update — 2026-10-10 (#59)

    Removed only the redundant empty root provider time block. Required-provider declarations, version pins and historical lock files remain unchanged. Implicit default provider resolution and existing time mocks still work.

    Fresh backend-disabled credential-free init/validate and 14 native cases pass. The reported time proxy deprecation warning was NOT reproduced on the pinned versions; existing Kubernetes deprecation warnings are unrelated. This is qualified redundant-block cleanup, not a claim to have reproduced that warning.

    Local working tree only, no release or historical plan/package rebinding. Issue remains open pending delivery.

  4. lweberru commented on Oct 16, 2026

    @lweberru
    Collaborator

    The deprecated empty root time-provider block is removed in #102 (the required_providers declaration remains). The targeted source diff removes only the unnecessary empty provider configuration; native initialization, validation and configuration tests pass in the integration CI.

    This fix will be linked for automatic closure with the integration merge. Repository-access permissions are not changed by this work; contribution through a fork/pull request remains supported and is documented in CONTRIBUTING.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    area:acceleratorAccelerator Terraform/OpenTofu roots, modules and exampleseffort:sSmall bounded change including regression tests and documentationneeds-investigationValidate API/provider behavior or product contract before implementationpriority:p3Lower urgency or optional extension

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions