Sync 2025.1 again - #2498
Merged
Merged
Conversation
Add alerts for `etcd` obtained from [1] [1]: https://samber.github.io/awesome-prometheus-alerts/rules/orchestrators/etcd/ Signed-off-by: Jack Hodgkiss <jack@stackhpc.com>
Previously there was a hostname-related OVN bug that required a reboot in the AIO CI instances to mitigate. It's been fixed for years[1] so this change reverts the workaround. It'll speed up CI and it's better to know if we regress. [1] https://bugs.launchpad.net/kolla-ansible/+bug/2080552
The previous Rocky 9.8 host image came with broken python 3.9 which caused issues starting deployments (`ASN1: NOT_ENOUGH_DATA`). An updated python package was released[0] and the host image has been rebuilt with this. OFED kernel module has been built for the latest kernel this image uses (`5.14.0.687.26.1.el9.8`). 0: https://errata.rockylinux.org/RLSA-2026:39798
Added Valkey migration script. This checks how `kolla_enable_redis`` is evaluated. If it's true, the script calls K-A's Valkey migration. Otherwise, it's a NOOP.
Remove hostname fix reboot
The GitHub app using it was turned off last summer [1]. [1] https://github.com/apps/product-auto-label
This switches to an IPA builder fork which is required for centos-10 stream IPA images, which are required (currently) to provide a version of qemu-img that can handle 4k sectors from Dell Perc RAID controllers which don't support other block sizes. Anyone not affected can carry on using stream-9 images until Rocky ones exist. We can drop this patch if we can backport https://review.opendev.org/c/openstack/ironic-python-agent-builder/+/995589
Update kolla_base_distro_version_default_map to select Rocky 9 or Rocky 10 images for each host.
Add coderabbit review configuration
Also ensure that the playbook is safe to run on Ubuntu.
Add hook to reset-bls-entries after host package update
This reverts commit d6b67b6. Reason for revert: fixes have been merged upstream.
Revert "GT-1835: Fix IPA for stream 10 (#2448)"
feat: add `prometheus` alerts for `etcd`
Signed-off-by: Jack Hodgkiss <jack@stackhpc.com>
feat: move release note to correct folder
This workflow should sync SKC with the upstream kayobe-config template. Unfortunately, it has never workedm because it has a different structure to standard openstack forks. Disabling it until we have time to properly investigate it.
Bump repositories and rebuild OFED
Kayobe expects hooks to end with a .yml extension.
Fix reset-bls-entries hook
…025.1 (automated) Bump dependencies for OpenStack stackhpc/2025.1
📝 WalkthroughRemoved the upstream synchronisation workflow. Added embedded etcd Prometheus alerts and connected the BLS reset hook. Updated DOCA OFED kernel versions for Rocky Linux 9.8 and 10.2. Added release notes for etcd alerts, kernel and Docker Engine updates, and security fixes. WalkthroughThe PR removes the upstream synchronisation workflow, adds embedded etcd Prometheus alerts, adds a BLS reset hook, updates Rocky Linux DOCA OFED versions, and adds release notes for monitoring, platform, and security updates. ChangesMonitoring and platform maintenance
Estimated code review effort: 3 (Moderate) | ~20 minutes Possibly related PRs
🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 4
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: ASSERTIVE
Plan: Pro Plus
Run ID: 34bf9806-e5ab-4c3f-bb24-ad1226887f20
📒 Files selected for processing (6)
.github/workflows/upstream-sync.ymletc/kayobe/hooks/overcloud-host-package-update/post.d/20-reset-bls-entries.ymletc/kayobe/kolla/config/prometheus/etcd.rulesetc/kayobe/ofed.ymlreleasenotes/notes/add-etcd-prometheus-alerts-f14710e37d97621f.yamlreleasenotes/notes/repo-bump-20260728-6cba5f6d572ebbfb.yaml
💤 Files with no reviewable changes (1)
- .github/workflows/upstream-sync.yml
📜 Review details
⏰ Context from checks skipped due to timeout. (6)
- GitHub Check: stackhpc/check
- GitHub Check: Tox docs with Python 3.12
- GitHub Check: Tox pep8 with Python 3.12
- GitHub Check: Ansible 2.20 lint with Python 3.12
- GitHub Check: Tox releasenotes with Python 3.12
- GitHub Check: Ansible 2.19 lint with Python 3.12
🔇 Additional comments (10)
etc/kayobe/hooks/overcloud-host-package-update/post.d/20-reset-bls-entries.yml (1)
1-1: LGTM!etc/kayobe/ofed.yml (1)
22-23: LGTM!releasenotes/notes/repo-bump-20260728-6cba5f6d572ebbfb.yaml (1)
1-15: LGTM!etc/kayobe/kolla/config/prometheus/etcd.rules (7)
16-32: LGTM!
34-54: LGTM!
56-65: LGTM!
97-131: LGTM!
151-167: LGTM!
169-186: LGTM!
4-6: 📐 Maintainability & Code QualityConfirm that
kolla-ansiblecopiesetcd.rules.This repository renders
rule_filesfrom an explicitprometheus_alert_rules.fileslist, butetc/kayobe/kolla/config/prometheus/etcd.rulesis only present as a Kolla config file. There is no traceable registration in this repository for that file. If Kolla does not copykolla/config/prometheus/*.rulesand does not pass them asPROMETHEUS_RULE_FILES/prometheusAlertRules, these alerts never load.
bbezak
approved these changes
Aug 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
9 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.