Synchronise master with upstream - #602
Merged
Merged
Conversation
Change-Id: I4c352ef16cfa9a423c6dae4a32b75d7c77e6720d Signed-off-by: Pierre Riteau <pierre@stackhpc.com>
Updates the Dell OS config template files to allow for whitespace in the descriptions. Closes-Bug:#2161899 Change-Id: I70e39d10c592639d0ae20080459babd6cdf5980a Signed-off-by: Leonie Chamberlin-Medd <leonie@stackhpc.com>
Change-Id: I263f8f4d388a175838662d72f3efe5b101e22c91 Signed-off-by: Pierre Riteau <pierre@stackhpc.com>
Change-Id: I1b12599dc2ed97954b28cfabe05811103056d7e4 Signed-off-by: Pierre Riteau <pierre@stackhpc.com>
The arista-switch role was failing to apply switch interface
configuration with an error such as:
fatal: [arista-switch]: FAILED! =>
changed: false
data: |-
description ceph1
% Invalid input
ARISTA-SWITCH(config-s-ansible_17)#
msg: |-
description ceph1
% Invalid input
ARISTA-SWITCH(config-s-ansible_17)#
This was caused by wrong indentation of the template, as described in
the collection documentation [1]:
The configuration lines in the source file should be similar to how
it will appear if present in the running-configuration (live switch
config) of the device including the indentation to ensure
idempotency and correct diff. Arista EOS device config has 3 spaces
indentation.
Also remove the exit statement which appears unneeded.
[1] https://docs.ansible.com/projects/ansible/latest/collections/arista/eos/eos_config_module.html
Closes-Bug: #2162130
Change-Id: I278897607d7f6375594cfa6341e16caefbc32fd0
Signed-off-by: Pierre Riteau <pierre@stackhpc.com>
Ironic recently added parsing of extra_kernel_params options [1]. Kayobe was generating "ipa-inspection-benchmarks=" when extra-hardware was disabled, which failed to validate. Update ipa_kernel_options_default to avoid producing kernel parameters with no value. [1] https://review.opendev.org/c/openstack/ironic/+/992306 Closes-Bug: #2162755 Change-Id: I35827eeb132fc7cd75a85aa0b33367d0a56dd33f Signed-off-by: Pierre Riteau <pierre@stackhpc.com>
Change-Id: I6b1e536c98ce0e8fc1fadc14883fa4115f23bfc0 Co-Authored-By: Rafal Lewandowski <rafal@stackhpc.com> Signed-off-by: Rafal Lewandowski <rafal@stackhpc.com> Signed-off-by: Pierre Riteau <pierre@stackhpc.com>
This allows us to install Kayobe without generating the configuration. This is useful when building a Docker image, where you want to install all dependencies at build time but do not require the runtime configuration. The runtime configuration can then be generated when the container is executed. Change-Id: I81c2b2a8e1ccde44854257ce8e34e3517c945a4d Signed-off-by: Will Szumski <will@stackhpc.com>
github-actions
Bot
added
the
automated
Alex-Welsh
approved these changes
Aug 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR contains a snapshot of master from upstream master.