fix: always create the workspace runfiles directory in the fallback tar#7
Merged
Conversation
Consumers set the image WorkingDir to /app/<workspace> so that runfiles-relative jvm_flags resolve, but the directory was only created when data runfiles existed. OCI runtimes fail chdir on a missing working directory, so images without data runfiles failed at container start. Add a repeatable --ensure_dir flag to jar_layerer and pass app/<ctx.workspace_name> from the rule unconditionally.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Consumers set the image WorkingDir to /app/ so that runfiles-relative jvm_flags resolve, but the directory was only created when data runfiles existed. OCI runtimes fail chdir on a missing working directory, so images without data runfiles failed at container start.
Add a repeatable --ensure_dir flag to jar_layerer and pass app/<ctx.workspace_name> from the rule unconditionally.