fix: replace deref with accessor function - #943
Open
adwk67 wants to merge 3 commits into
Open
Conversation
20 tasks
adwk67
marked this pull request as ready for review
September 10, 2026 15:47
siegfriedweber
self-requested a review
September 10, 2026 16:23
siegfriedweber
requested changes
Sep 10, 2026
Member
There was a problem hiding this comment.
In my opinion, the container name should always come from the same source, i.e. name():
- &crate::crd::Container::PasswordFileUpdater.to_string(),
+ crate::crd::Container::PasswordFileUpdater.name().as_ref(),The comment for the test case container_names_match_display can then be adapted, because Display is not used anymore for log capture:
/// The typed container names returned by `name` must agree with the strum `Display` of
/// `Container`, which the logging configuration uses as the per-container key.
Member
There was a problem hiding this comment.
The comment is not adapted yet:
trino-operator/rust/operator-binary/src/crd/mod.rs
Lines 642 to 643 in fdd3637
Display is not used for log capture anymore.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Part of stackabletech/issues#883
Definition of Done Checklist
Author
Reviewer
Acceptance
type/deprecationlabel & add to the deprecation scheduletype/experimentallabel & add to the experimental features tracker