fix: Correctly migrate SECRET_KEY from 26.3 setups#754
Merged
Conversation
NickLarsenNZ
previously approved these changes
Jul 10, 2026
20 tasks
Member
Author
Member
Author
|
Tests passed, did some manual upgrade testing |
SECRET_KEY from 26.3 setups
18 tasks
Techassi
reviewed
Jul 10, 2026
Techassi
left a comment
Member
There was a problem hiding this comment.
Mostly lgtm, just two minor comments.
Co-authored-by: Techassi <git@techassi.dev>
Techassi
approved these changes
Jul 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes #753
We basically lookup
connection.secretKeyfrom the old credentials Secret and use that as theSECRET_KEY. If - for some reason, e.g. fresh setup - it doesn't exist we still create a random value (as we currently do)We had to revert the
credentialsSecret->credentialsSecretNamerename, as otherwise the operator would reconcile the CRD on startup. This would in turn result in thecredentialsSecretbeing dropped, so we loos the information how the old Secret was called.Definition of Done Checklist
Author
Reviewer
Acceptance
type/deprecationlabel & add to the deprecation scheduletype/experimentallabel & add to the experimental features tracker