Skip to content

feat: Management Access utilities - #1290

Merged
Techassi merged 36 commits into
mainfrom
feat/platform-access
Nov 3, 2026
Merged

feat: Management Access utilities#1290
Techassi merged 36 commits into
mainfrom
feat/platform-access

Conversation

@labrenbe

@labrenbe labrenbe commented Oct 1, 2026 •
edited
Loading

Copy link
Copy Markdown
Member

Description

Part of stackabletech/issues#888.

Adds shared utilities required for stackabletech/kafka-operator#1028.

  • labels and selectors for agents
  • new enum for platform access with TLS

Depends on https://github.com/stackabletech/decisions/issues/98 and https://github.com/stackabletech/decisions/issues/99.

Definition of Done Checklist

  • Not all of these items are applicable to all PRs, the author should update this template to only leave the boxes in that are relevant
  • Please make sure all these things are done and tick the boxes

Author

  • Changes are OpenShift compatible
  • CRD changes approved
  • CRD documentation for all fields, following the style guide.
  • Integration tests passed (for non trivial changes)
  • Changes need to be "offline" compatible

Reviewer

  • Code contains useful comments
  • Code contains useful logging statements
  • (Integration-)Test cases added
  • Documentation added or updated. Follows the style guide.
  • Changelog updated
  • Cargo.toml only contains references to git tags (not specific commits or branches)

Acceptance

  • Feature Tracker has been updated
  • Proper release label has been added

@labrenbe labrenbe self-assigned this Oct 1, 2026
@labrenbe
labrenbe force-pushed the feat/platform-access branch from c3e3121 to 3be4832 Compare October 1, 2026 12:09
@labrenbe
labrenbe force-pushed the feat/platform-access branch from 3be4832 to 7cb677e Compare October 1, 2026 12:12
@labrenbe labrenbe mentioned this pull request Oct 2, 2026
Open
6 of 20 tasks
maltesander
maltesander reviewed Oct 13, 2026
View reviewed changes
Comment thread crates/stackable-agent/src/condition.rs Resolved
adwk67
adwk67 reviewed Oct 21, 2026
View reviewed changes
Comment thread crates/stackable-operator/src/v2/kvp/label.rs Resolved
@labrenbe labrenbe changed the title feat: Platform Access utilities feat: Management Access utilities Oct 23, 2026
@labrenbe
labrenbe force-pushed the feat/platform-access branch from 586debd to 22536cd Compare October 23, 2026 16:06
@labrenbe

This comment was marked as outdated.

Sign in to view
maltesander
maltesander reviewed Nov 2, 2026
View reviewed changes
Comment thread crates/stackable-agent/CHANGELOG.md Resolved
@Techassi Techassi mentioned this pull request Nov 2, 2026
Merged
@Techassi

Techassi commented Nov 2, 2026 •
edited
Loading

Copy link
Copy Markdown
Member

The Clippy errors are a false-positive btw. Fixed in #1323.

Once this is approved, an admin can force-merge this.

maltesander
maltesander previously approved these changes Nov 2, 2026
View reviewed changes

@maltesander maltesander left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

maltesander
maltesander previously approved these changes Nov 2, 2026
View reviewed changes

@maltesander maltesander left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@Techassi
fix: Temporarily allow redundant_field_names lint
1d2bf3f 
We need to allow this lint temporarily because it seems to be a
false-positive trigger.
@Techassi
chore: Fix various Clippy errors
fe34baf
@Techassi
chore: Add link to darling fix PR
bc7e95f
@Techassi

Techassi commented Nov 3, 2026 •
edited
Loading

Copy link
Copy Markdown
Member

Once this is approved, an admin can force-merge this.

We instead decided to cherry-pick the fixes needed. @NickLarsenNZ will review and approve.

NickLarsenNZ
NickLarsenNZ approved these changes Nov 3, 2026
View reviewed changes

@NickLarsenNZ NickLarsenNZ left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed the previous 3 commits. LGTM

@Techassi
Techassi added this pull request to the merge queue Nov 3, 2026
Merged via the queue into main with commit dc87825 Nov 3, 2026
5 checks passed
@Techassi
Techassi deleted the feat/platform-access branch November 3, 2026 08:34
@Techassi Techassi moved this from Development: In Review to Development: Done in Stackable Engineering Nov 3, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@adwk67 adwk67 adwk67 left review comments
@Techassi Techassi Techassi left review comments
@xeniape xeniape xeniape left review comments
@sbernauer sbernauer sbernauer left review comments
@NickLarsenNZ NickLarsenNZ NickLarsenNZ approved these changes
@maltesander maltesander maltesander left review comments

Assignees

@labrenbe labrenbe

Labels

release/26.11.0

Projects

Stackable Engineering
Status: Development: Done

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@labrenbe @xeniape @sbernauer @Techassi @adwk67 @NickLarsenNZ @maltesander