Skip to content

fix: Fix the JSON schema of JsonConfigOverrides#1245

Merged
siegfriedweber merged 3 commits into
mainfrom
fix/jsonconfigoverrides-schema
Jul 7, 2026
Merged

fix: Fix the JSON schema of JsonConfigOverrides#1245
siegfriedweber merged 3 commits into
mainfrom
fix/jsonconfigoverrides-schema

Conversation

@siegfriedweber

Copy link
Copy Markdown
Member

Description

Fix the JSON schema of JsonConfigOverrides

Definition of Done Checklist

  • Not all of these items are applicable to all PRs, the author should update this template to only leave the boxes in that are relevant
  • Please make sure all these things are done and tick the boxes

Author

Reviewer

  • Code contains useful comments
  • Code contains useful logging statements
  • (Integration-)Test cases added
  • Documentation added or updated. Follows the style guide.
  • Changelog updated
  • Cargo.toml only contains references to git tags (not specific commits or branches)

Acceptance

  • Feature Tracker has been updated
  • Proper release label has been added

@siegfriedweber siegfriedweber self-assigned this Jul 7, 2026
@siegfriedweber siegfriedweber moved this to Development: Waiting for Review in Stackable Engineering Jul 7, 2026
@sbernauer sbernauer self-requested a review July 7, 2026 12:19
@sbernauer sbernauer moved this from Development: Waiting for Review to Development: In Review in Stackable Engineering Jul 7, 2026
sbernauer
sbernauer previously approved these changes Jul 7, 2026
Comment thread crates/stackable-operator/crds/DummyCluster.yaml Outdated
adwk67
adwk67 previously approved these changes Jul 7, 2026

@adwk67 adwk67 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

jsonPatch: array (real RFC-6902), previously rejected at admission, is now admitted + reconciled:

$ kubectl apply --dry-run=server -n render-diff -f - <<'EOF'
apiVersion: opa.stackable.tech/v1alpha2
kind: OpaCluster
metadata:
  name: jsonpatch-repro
spec:
  image:
    productVersion: "1.16.2"
  servers:
    configOverrides:
      config.json:
        jsonPatch:
          - op: add
            path: /default_decision
            value: allow
    roleGroups:
      default: {}
EOF
opacluster.opa.stackable.tech/jsonpatch-repro created (server dry run)

@siegfriedweber siegfriedweber dismissed stale reviews from adwk67 and sbernauer via 3b98323 July 7, 2026 13:24
@siegfriedweber siegfriedweber added this pull request to the merge queue Jul 7, 2026
@siegfriedweber siegfriedweber moved this from Development: In Review to Development: Done in Stackable Engineering Jul 7, 2026
Merged via the queue into main with commit 052ede7 Jul 7, 2026
5 checks passed
@siegfriedweber siegfriedweber deleted the fix/jsonconfigoverrides-schema branch July 7, 2026 13:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Development: Done

Development

Successfully merging this pull request may close these issues.

3 participants