Skip to content

refactor: Extract apply and update status steps - #811

Open
adwk67 wants to merge 1 commit into
mainfrom
feat/smooth-operator/extract-apply-step
Open

refactor: Extract apply and update status steps#811
adwk67 wants to merge 1 commit into
mainfrom
feat/smooth-operator/extract-apply-step

Conversation

@adwk67

@adwk67 adwk67 commented Jul 30, 2026

Copy link
Copy Markdown
Member

Description

This PR covers the following:

  • extracts apply and update_status steps
  • moves secret creation to the apply step

Definition of Done Checklist

  • Not all of these items are applicable to all PRs, the author should update this template to only leave the boxes in that are relevant
  • Please make sure all these things are done and tick the boxes

Author

  • Changes are OpenShift compatible
  • CRD changes approved
  • CRD documentation for all fields, following the style guide.
  • Helm chart can be installed and deployed operator works
  • Integration tests passed (for non trivial changes)
  • Changes need to be "offline" compatible
  • Links to generated (nightly) docs added
  • Release note snippet added

Reviewer

  • Code contains useful comments
  • Code contains useful logging statements
  • (Integration-)Test cases added
  • Documentation added or updated. Follows the style guide.
  • Changelog updated
  • Cargo.toml only contains references to git tags (not specific commits or branches)

Acceptance

  • Feature Tracker has been updated
  • Proper release label has been added
  • Links to generated (nightly) docs added
  • Release note snippet added
  • Add type/deprecation label & add to the deprecation schedule
  • Add type/experimental label & add to the experimental features tracker

// Discovery CM will fail to build until the rest of the cluster has been
// deployed, so do it last so that failure won't inhibit the rest of the
// cluster from booting up.
let discovery_cm = build_discovery_config_map(

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This - build_discovery_config_map - is a build step, but it cannot live in the "actual" step (due to dependencies) but neither is it really part of apply, so I've left it here.

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This will be covered by our TODO item:

Address the race condition for discovery config maps: see HDFS, Hive, Kafka

) -> Result<AppliedResources> {
// Destructured without `..`, so adding a field to [`KubernetesResources`] fails to
// compile here instead of silently never being applied.
let KubernetesResources {

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Things would be brittle if we didn't first check we have actually retrieved everthing that KubernetesResources holds.

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also added to the PRs for Druid, HBase.

@adwk67 adwk67 self-assigned this Jul 31, 2026
@adwk67
adwk67 marked this pull request as ready for review July 31, 2026 11:08
@adwk67

adwk67 commented Jul 31, 2026

Copy link
Copy Markdown
Member Author
--- PASS: kuttl (741.03s)
    --- PASS: kuttl/harness (0.00s)
        --- PASS: kuttl/harness/smoke_hadoop-3.5.0_zookeeper-3.9.4_zookeeper-latest-3.9.5_number-of-datanodes-2_datanode-pvcs-2hdd-1ssd_listener-class-cluster-internal_openshift-false (327.98s)
        --- PASS: kuttl/harness/smoke_hadoop-3.5.0_zookeeper-3.9.4_zookeeper-latest-3.9.5_number-of-datanodes-2_datanode-pvcs-2hdd-1ssd_listener-class-external-unstable_openshift-false (159.48s)
        --- PASS: kuttl/harness/smoke_hadoop-3.5.0_zookeeper-3.9.5_zookeeper-latest-3.9.5_number-of-datanodes-2_datanode-pvcs-2hdd-1ssd_listener-class-external-unstable_openshift-false (184.41s)
        --- PASS: kuttl/harness/smoke_hadoop-3.5.0_zookeeper-3.9.5_zookeeper-latest-3.9.5_number-of-datanodes-2_datanode-pvcs-2hdd-1ssd_listener-class-cluster-internal_openshift-false (741.02s)
PASS

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant