refactor: Extract apply and update status steps - #811
Open
adwk67 wants to merge 1 commit into
Open
Conversation
12 tasks
adwk67
commented
Jul 31, 2026
| // Discovery CM will fail to build until the rest of the cluster has been | ||
| // deployed, so do it last so that failure won't inhibit the rest of the | ||
| // cluster from booting up. | ||
| let discovery_cm = build_discovery_config_map( |
Member
Author
There was a problem hiding this comment.
This - build_discovery_config_map - is a build step, but it cannot live in the "actual" step (due to dependencies) but neither is it really part of apply, so I've left it here.
Member
Author
There was a problem hiding this comment.
This will be covered by our TODO item:
Address the race condition for discovery config maps: see HDFS, Hive, Kafka
adwk67
commented
Jul 31, 2026
| ) -> Result<AppliedResources> { | ||
| // Destructured without `..`, so adding a field to [`KubernetesResources`] fails to | ||
| // compile here instead of silently never being applied. | ||
| let KubernetesResources { |
Member
Author
There was a problem hiding this comment.
Things would be brittle if we didn't first check we have actually retrieved everthing that KubernetesResources holds.
Member
Author
There was a problem hiding this comment.
Also added to the PRs for Druid, HBase.
adwk67
marked this pull request as ready for review
July 31, 2026 11:08
Member
Author
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR covers the following:
Definition of Done Checklist
Author
Reviewer
Acceptance
type/deprecationlabel & add to the deprecation scheduletype/experimentallabel & add to the experimental features tracker