chore(boil): Remove some dead code - #1660
Merged
Merged
Conversation
We ideally want dead_code_pub_in_binary = "warn", but that is currently nightly only and produces noise when running unit tests. For now, we could replace all pub items with pub(crate) to get proper dead code warnings again.
lfrancke
previously approved these changes
Sep 16, 2026
lfrancke
moved this from Development: Waiting for Review
to Development: In Review
in Stackable Engineering
Member
|
You're running into the same rustls issues I did yesterday :( |
Member
Author
|
Hehe yeah, I have been dealing with them yesterday and today as well. I will bump the crate to address the failure. |
lfrancke
approved these changes
Sep 16, 2026
Techassi
moved this from Development: In Review
to Development: Done
in Stackable Engineering
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We ideally want
dead_code_pub_in_binary = "warn", but that is currently nightly only and produces noise when running unit tests. See rust-lang/rust#74970.For now, we could replace all
pubitems withpub(crate)to get proper dead code warnings again.