Feat/s3 file browser v1 by dklOrdix · Pull Request #208 · stackabletech/cockpit

dklOrdix · 2026-06-18T11:08:13Z

Closes #129

…in +layout.svelte

…ebar imports Co-authored-by: Copilot <copilot@github.com>

Co-authored-by: Copilot <copilot@github.com>

…s/utils Co-authored-by: Copilot <copilot@github.com>

Co-authored-by: Copilot <copilot@github.com>

feat(storage): initial Filebrowser UI implementation

Co-authored-by: Copilot <copilot@github.com>

…ation S3 File Browser Page Navigation (Pagination)

* #96 disable the storage browser if feature flag is set * #96 fix svelte-check * #96 fix lint * #96 disable storage browser by default

* #102 refactor pagination controls into a separate component * #102 simplified pagination props

* #93 add modal preview for file display * #93 fix broken e2e tests * #93 add preview for parquet files, fix scrollbar visibility in preview, allow ms excel csv data for preview * #93 improve parquet row fetch handling * #93 fix lint * #93 move preview endpoint logic into separate files * #93 disable parquet preview

* refactor(ObjectTable): extract File and Folde rows into seperate components * style: format code * style: use camelCase * style: use camelCase

* feat: implement single-file download functionality and error handling for S3 storage * feat: refactor S3 download endpoint to use new API structure and improve error handling * chore: remove obsolete note about static download route segment in tech debt documentation * style: format code * fix: improve type safety in S3 error handling * fix: preview action * feat: add context menu header and improve file selection handling in FileExplorer * fix: reset selection state on context menu close and refine download action logic * style: format files * style: remove pointer events from Actions row on ContextMenu * #91 fix lint --------- Co-authored-by: F3l1x1vo <fli@ordix.de>

…history now overflows, fix TSV preview

F3l1x1vo · 2026-09-04T11:19:32Z

@copilot resolve the merge conflicts in this pull request

F3l1x1vo · 2026-09-04T11:22:48Z

@copilot resolve the merge conflicts in this pull request

Copilot · 2026-09-04T11:30:50Z

@copilot resolve the merge conflicts in this pull request

Resolved by merging the current main branch in commit 108741f.

… buckets

stackable-cla · 2026-09-10T10:12:42Z

Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
0 out of 2 committers have signed the CLA.

❌ dklOrdix
❌ F3l1x1vo
_{You have signed the CLA already but the status is still pending? Let us recheck it.}

# Conflicts: # TECH_DEBT.md # src/lib/server/trino/queries.ts # vite.config.ts

lfrancke · 2026-09-09T16:03:54Z

+if (cleanupTimer.unref) cleanupTimer.unref();
+
+function cacheKey(bucket: string, key: string): string {
+  return `${bucket}:${key}`;


I'm fairly certain this could leak data between users if you create buckets with the same name. This needs the connection id (which can't just be the URL was we just learned in the key.

lfrancke · 2026-09-10T09:47:47Z

+    const KNOWN_VIOLATIONS = [
+      'ToastHost.svelte',
+      'TextEditor.svelte',
+      'ContextMenu.svelte',
+      'FileRow.svelte',
+      'FolderRow.svelte',
+      'ObjectTable.svelte',
+      'StorageBreadcrumb.svelte',
+      'CsvPreview.svelte',
+      'ParquetPreview.svelte',
+      'TextPreview.svelte'
+    ];


Aren't a whole bunch of these added by you?

lfrancke · 2026-09-10T09:48:26Z

+ * against further growth. Tighten them as large files are split during normal
+ * refactoring cycles.
+ *
+ * Current maximums (non-generated):


This is just bound to become outdated... this comment I mean.

dklOrdix and others added 30 commits May 4, 2026 09:18

refactor(frontend): clean up and restructure app

161ce0e

fix: add lint:fix script to package.json and clean up trailing comma …

d2de208

…in +layout.svelte

docs: update AGENTS.md to include Material UI icon library usage

c81b4d0

refactor(header): move components for header into own directory

9add069

chore: dedupe lockfile

8343022

fix(sidebar): add hover cursor style to toggle button

4bc8e93

chore(types): centralise navigation and auth types; update header/sid…

952dc80

…ebar imports Co-authored-by: Copilot <copilot@github.com>

feat(storage): initial Filebrowser UI implementation

cba7866

Co-authored-by: Copilot <copilot@github.com>

refactor(storage): extract service layer and consolidate storage type…

5de8d9f

…s/utils Co-authored-by: Copilot <copilot@github.com>

Merge branch 'feat/s3-file-browser' into feat/s3-file-browser-ui

20909ae

chore(storage): remove outdated STORAGE_REORG_PLAN.md

2b33533

fix(lint): resolve errors

aeac85d

refactor(tests): update ThemeToggle tests to use checkbox role

f2ba284

Co-authored-by: Copilot <copilot@github.com>

style: format code

af9b651

fix(tests): update theme toggle role from button to checkbox

8373974

Co-authored-by: Copilot <copilot@github.com>

fix: revert changes to Theme Toggle

7aff59b

fix: revert changes to Theme Toggle

266a045

Merge pull request #90 from stackabletech/feat/s3-file-browser-ui

805f693

feat(storage): initial Filebrowser UI implementation

#80 use pagination controls to navigate the file browser

3386182

#80 show page counter for pagination control

b77bcfa

Co-authored-by: Copilot <copilot@github.com>

#80 fix lint and svelte check

48b552e

Co-authored-by: Copilot <copilot@github.com>

fix lint error

7c9733f

Merge pull request #100 from stackabletech/feat/s3-file-browser-pagin…

9d85f57

…ation S3 File Browser Page Navigation (Pagination)

File Browser: Feature Flag (#105)

b4e25ec

* #96 disable the storage browser if feature flag is set * #96 fix svelte-check * #96 fix lint * #96 disable storage browser by default

Rename option STACKABLE_UI_COMPLETION_DISABLED (#106)

c36f1c8

S3 File Browser: Shared Pagination Component (#103)

ff43b22

* #102 refactor pagination controls into a separate component * #102 simplified pagination props

Merge branch 'main' into feat/s3-file-browser

ed9be69

Feat/s3 file browser refactor object table (#120)

184fa84

* refactor(ObjectTable): extract File and Folde rows into seperate components * style: format code * style: use camelCase * style: use camelCase

lfrancke mentioned this pull request Aug 25, 2026

epic: First Release Cockpit #294

Open

14 tasks

F3l1x1vo added 14 commits August 31, 2026 07:47

#208 fix actions tooltip, show parquet line number only on data tab

ea867b6

use tabs by default, fix tooltips, rename storage routes, operations …

416e78c

…history now overflows, fix TSV preview

fix tab and bucket switching behavior

f9bd54d

Merge branch 'main' into feat/s3-file-browser-v1

c3da477

remove close button

6737272

fix lint

f29eedf

fix history.pushState

b0ada4c

add nvm version

84df7be

fix unit and e2e tests

297fcc6

Merge branch 'main' into feat/s3-file-browser-v1

aac2e50

remove mobile e2e test config

b828fb6

fix e2e tests

4f42efb

Merge branch 'main' into feat/s3-file-browser-v1

e53d280

Merge branch 'main' into feat/s3-file-browser-v1

22bbf4c

Copilot started work on behalf of F3l1x1vo September 4, 2026 11:19 View session

Copilot stopped work on behalf of F3l1x1vo due to an error September 4, 2026 11:20
Request session.create failed with message: Model "claude-sonnet-4.6" is not available.

Copilot started work on behalf of F3l1x1vo September 4, 2026 11:23 View session

Copilot finished work on behalf of F3l1x1vo September 4, 2026 11:31

Merge origin/main into feat/s3-file-browser-v1

cc88897

F3l1x1vo force-pushed the feat/s3-file-browser-v1 branch from 108741f to cc88897 Compare September 4, 2026 12:07

F3l1x1vo added 3 commits September 4, 2026 14:08

Merge branch 'main' into feat/s3-file-browser-v1

cb1eec5

Merge branch 'main' into feat/s3-file-browser-v1

cc979f0

fix tab switching issue of not being able to navigate inside multiple…

e582f1d

… buckets

Merge remote-tracking branch 'origin/main' into feat/s3-file-browser-v1

18190cd

# Conflicts: # TECH_DEBT.md # src/lib/server/trino/queries.ts # vite.config.ts

lfrancke requested changes Sep 10, 2026

View reviewed changes

Navigation Menu

Uh oh!

Uh oh!

Feat/s3 file browser v1 - #208

Feat/s3 file browser v1#208
dklOrdix wants to merge 161 commits into
mainfrom
feat/s3-file-browser-v1

dklOrdix commented Jun 18, 2026 •

edited by F3l1x1vo

Loading

Uh oh!

F3l1x1vo commented Sep 4, 2026

Uh oh!

F3l1x1vo commented Sep 4, 2026

Uh oh!

Copilot AI commented Sep 4, 2026

Uh oh!

stackable-cla Bot commented Sep 10, 2026

Uh oh!

lfrancke Sep 9, 2026

Uh oh!

lfrancke Sep 10, 2026

Uh oh!

lfrancke Sep 10, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Uh oh!

Uh oh!

Conversation

dklOrdix commented Jun 18, 2026 • edited by F3l1x1vo Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

F3l1x1vo commented Sep 4, 2026

Uh oh!

F3l1x1vo commented Sep 4, 2026

Uh oh!

Copilot AI commented Sep 4, 2026

Uh oh!

stackable-cla Bot commented Sep 10, 2026

Uh oh!

lfrancke Sep 9, 2026

Choose a reason for hiding this comment

Uh oh!

lfrancke Sep 10, 2026

Choose a reason for hiding this comment

Uh oh!

lfrancke Sep 10, 2026

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

dklOrdix commented Jun 18, 2026 •

edited by F3l1x1vo

Loading