fix: make container name accessor infallible

[adwk67]

Description

Part of stackabletech/issues#883

Definition of Done Checklist

• Not all of these items are applicable to all PRs, the author should update this template to only leave the boxes in that are relevant
• Please make sure all these things are done and tick the boxes

Author

• Changes are OpenShift compatible
• CRD changes approved
• CRD documentation for all fields, following the style guide.
• Helm chart can be installed and deployed operator works
• Integration tests passed (for non trivial changes)
• Changes need to be "offline" compatible
• Links to generated (nightly) docs added
• Release note snippet added

Reviewer

• Code contains useful comments
• (Integration-)Test cases added
• Changelog updated
• Cargo.toml only contains references to git tags (not specific commits or branches)

Acceptance

• Feature Tracker has been updated
• Proper release label has been added
• Links to generated (nightly) docs added
• Release note snippet added
• Add type/deprecation label & add to the deprecation schedule
• Add type/experimental label & add to the experimental features tracker

[siegfriedweber]

LGTM

Only one nit:

The METRICS_CONTAINER_NAME is handled differently from the other container names. It is not part of the Container enum, presumably because it should not be exposed in the log configuration. Can we just add a comment like "the metrics container has no logging configuration, so it is not a Container variant and carries its name directly"?

[adwk67]

LGTM

Only one nit:

The METRICS_CONTAINER_NAME is handled differently from the other container names. It is not part of the Container enum, presumably because it should not be exposed in the log configuration. Can we just add a comment like "the metrics container has no logging configuration, so it is not a Container variant and carries its name directly"?

ec70a1f