ci: replace SourceKnight with native GitHub Actions workflow - #22
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
This PR completes the SourceKnight-to-native GitHub Actions migration for VIP Core by removing sourceknight.yaml and consolidating build/tag/release behavior into a single org-standard ci.yml workflow, while cleaning up remaining SourceKnight references in repo metadata/docs.
Changes:
- Added a new
.github/workflows/ci.ymlworkflow that builds with SourceMod 1.12.x and handleslatesttagging + release packaging. - Removed legacy build configuration (
sourceknight.yamland.github/workflows/build.yml) and cleaned up.gitignore. - Updated
.github/copilot-instructions.mdto reflect the new CI workflow and build command.
Reviewed changes
Copilot reviewed 4 out of 5 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
sourceknight.yaml |
Removed SourceKnight metadata now superseded by native GitHub Actions. |
.gitignore |
Removed .sourceknight ignore entry. |
.github/workflows/ci.yml |
Introduced standardized CI build + tag + release workflow. |
.github/workflows/build.yml |
Removed the old matrix-based build/release workflow. |
.github/copilot-instructions.md |
Updated documentation to reference the new workflow/build command. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Comment on lines
+25
to
+30
| - name: Create package | ||
| run: | | ||
| set -euo pipefail | ||
| mkdir -p /tmp/package/addons/sourcemod/plugins | ||
| cp addons/sourcemod/plugins/*.smx /tmp/package/addons/sourcemod/plugins/ | ||
|
|
Comment on lines
+3
to
+5
| on: [push, pull_request, workflow_dispatch] | ||
|
|
||
| jobs: |
Comment on lines
+48
to
+50
| - **CI/CD**: GitHub Actions (`.github/workflows/ci.yml`) | ||
| - **Dependency Management**: none (no external SourcePawn include dependencies beyond SourceMod itself) | ||
| - **Compilation**: `spcomp -i include -o ../plugins/VIP_Core.smx VIP_Core.sp` |
Rushaway
force-pushed
the
chore/drop-sourceknight
branch
from
August 18, 2026 11:16
1b0a088 to
deda216
Compare
Rushaway
force-pushed
the
chore/drop-sourceknight
branch
from
August 18, 2026 11:20
deda216 to
4aca609
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This repo already had a mostly-native GitHub Actions build (
.github/workflows/build.yml), but dependency/version metadata still lived insourceknight.yaml. This PR replaces it with the standardci.ymlworkflow used across the org-wide SourceKnight migration (same job structure, tag/release logic, and action pins as the validatedsrcdslab/sm-plugin-AdminRoomtemplate), removessourceknight.yaml, and cleans up the remaining references to SourceKnight in.gitignoreand.github/copilot-instructions.md.The old
build.ymlcompiled against a1.11.x/1.12.xmatrix withcontinue-on-erroron 1.12; the new workflow standardizes on SourceMod 1.12 (the version declared insourceknight.yaml), matching every other migrated repo.Plugins compiled
addons/sourcemod/scripting/VIP_Core.spVIP_Core.smxDependencies cloned
None.
sourceknight.yamldeclared only thesourcemodtype: tarruntime dependency (version 1.12), which is handled byrumblefrog/setup-sp. There are notype: gitdependencies — the plugin's only include (vip_core.inc) is local to the repo ataddons/sourcemod/scripting/include/.No
common/folder exists at the repo root, so nothing extra is bundled into the release package.Local validation performed
Compiled the real target locally with a version-matched SourceMod 1.12
spcompbinary, replicating the generated CI build step exactly:Result: compiled successfully with no errors or warnings, producing
VIP_Core.smx.Manual verification needed
continue-on-error). This PR standardizes on 1.12 only, matching the version pinned insourceknight.yamland the org's template. If 1.11 compatibility is still required, that should be reconsidered separately.README.mdcontains a build badge pointing atgithub.com/R1KO/VIP-Core(an upstream fork), notsrcdslab/sm-plugin-VIP-Core. It does not reference SourceKnight, so it was left untouched, but it looks stale/incorrect independent of this migration — flagging for a human to decide whether to fix it.