Skip to content

ci: replace SourceKnight with native GitHub Actions workflow - #24

Merged
Rushaway merged 1 commit into
masterfrom
chore/drop-sourceknight
Aug 18, 2026
Merged

ci: replace SourceKnight with native GitHub Actions workflow#24
Rushaway merged 1 commit into
masterfrom
chore/drop-sourceknight

Conversation

@Rushaway

Copy link
Copy Markdown
Member

Summary

Plugins compiled

Target Source file
entwatch_dz addons/sourcemod/scripting/entwatch_dz.sp
entwatch_logs_manager addons/sourcemod/scripting/entwatch_logs_manager.sp
VIP_EntWatch addons/sourcemod/scripting/VIP_EntWatch.sp

SourceMod/SourcePawn compiler version: 1.12.x (sourceknight.yaml declared 1.12.0-git7137), via rumblefrog/setup-sp@v1.3.1.

Dependencies cloned

Name Repo Real include path used
multicolors https://github.com/Bara/Multi-Colors addons/sourcemod/scripting/include/ (matches yaml)
discordwebhookapi https://github.com/Sarrus1/DiscordWebhookAPI include/ (matches yaml)
vip_core https://github.com/R1KO/VIP-Core addons/sourcemod/scripting/include/ (matches yaml)
Extended-Discord https://github.com/srcdslab/sm-plugin-Extended-Discord addons/sourcemod/scripting/include/ (matches yaml)

All four dependency layouts matched what sourceknight.yaml declared — no non-standard nesting found.

No root-level common/ folder exists in this repo, so no common-folder packaging step was added to the workflow.

Local validation performed

Actually ran spcomp (SourcePawn Compiler 1.12.0.7246, matching the cached 1.12 binary) locally, replicating the generated workflow's build step exactly: cloned all four git dependencies for real, assembled them into addons/sourcemod/scripting/include/, and compiled all three targets with spcomp -i include -o ../plugins/<target>.smx <target>.sp. All three compiled successfully with exit code 0 and no errors:

  • entwatch_dz.sp → OK
  • entwatch_logs_manager.sp → OK
  • VIP_EntWatch.sp → OK

Manual verification needed

  • The previous SourceKnight-based ci.yml copied addons/sourcemod/translations/ and cfg/ into the release package (under a common/ structure inside the build artifact), so end-user release tarballs previously included translation files and default cfg files alongside the compiled .smx plugins. The new workflow, following the validated reference template exactly, only packages the compiled .smx files (the template's contract is: bundle a root-level common/ folder if one exists, and this repo has no such folder — it has cfg/ and addons/sourcemod/translations/ instead, which don't match that exact convention). A human should decide whether cfg/ and addons/sourcemod/translations/ should also be bundled into the release artifact (e.g. by adding a repo-specific copy step), since this is a behavior change from the previous workflow.

@Rushaway
Rushaway requested a lite review from Copilot August 17, 2026 06:49

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

@Rushaway
Rushaway force-pushed the chore/drop-sourceknight branch 2 times, most recently from 6f674db to fe21bc9 Compare August 18, 2026 11:20
@Rushaway
Rushaway force-pushed the chore/drop-sourceknight branch from fe21bc9 to 6e0b7a5 Compare August 18, 2026 11:21
@Rushaway
Rushaway merged commit e45664c into master Aug 18, 2026
6 checks passed
@Rushaway
Rushaway deleted the chore/drop-sourceknight branch August 18, 2026 11:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants