ci: replace SourceKnight with native GitHub Actions workflow - #24
Merged
Conversation
Rushaway
force-pushed
the
chore/drop-sourceknight
branch
2 times, most recently
from
August 18, 2026 11:20
6f674db to
fe21bc9
Compare
Rushaway
force-pushed
the
chore/drop-sourceknight
branch
from
August 18, 2026 11:21
fe21bc9 to
6e0b7a5
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
maxime1907/action-sourceknight) with a native GitHub Actions workflow, following the pattern already validated insrcdslab/sm-plugin-AdminRoom(PR fix: Improve RegisterButton function (#29) + Small DRY darkerz7/EntWatch_DZ#30/feat: Status show ebans number of client darkerz7/EntWatch_DZ#31).sourceknight.yaml(no.sourceknight/directory was present) and the.sourceknightentry from.gitignore.Plugins compiled
addons/sourcemod/scripting/entwatch_dz.spaddons/sourcemod/scripting/entwatch_logs_manager.spaddons/sourcemod/scripting/VIP_EntWatch.spSourceMod/SourcePawn compiler version:
1.12.x(sourceknight.yaml declared1.12.0-git7137), viarumblefrog/setup-sp@v1.3.1.Dependencies cloned
addons/sourcemod/scripting/include/(matches yaml)include/(matches yaml)addons/sourcemod/scripting/include/(matches yaml)addons/sourcemod/scripting/include/(matches yaml)All four dependency layouts matched what
sourceknight.yamldeclared — no non-standard nesting found.No root-level
common/folder exists in this repo, so no common-folder packaging step was added to the workflow.Local validation performed
Actually ran
spcomp(SourcePawn Compiler 1.12.0.7246, matching the cached 1.12 binary) locally, replicating the generated workflow's build step exactly: cloned all four git dependencies for real, assembled them intoaddons/sourcemod/scripting/include/, and compiled all three targets withspcomp -i include -o ../plugins/<target>.smx <target>.sp. All three compiled successfully with exit code 0 and no errors:entwatch_dz.sp→ OKentwatch_logs_manager.sp→ OKVIP_EntWatch.sp→ OKManual verification needed
ci.ymlcopiedaddons/sourcemod/translations/andcfg/into the release package (under acommon/structure inside the build artifact), so end-user release tarballs previously included translation files and default cfg files alongside the compiled.smxplugins. The new workflow, following the validated reference template exactly, only packages the compiled.smxfiles (the template's contract is: bundle a root-levelcommon/folder if one exists, and this repo has no such folder — it hascfg/andaddons/sourcemod/translations/instead, which don't match that exact convention). A human should decide whethercfg/andaddons/sourcemod/translations/should also be bundled into the release artifact (e.g. by adding a repo-specific copy step), since this is a behavior change from the previous workflow.