Skip to content

Fix translations build logging when translation is disabled - #2468

Closed
kinkie wants to merge 1 commit into
squid-cache:masterfrom
kinkie:fix-translations-output-nit
Closed

Fix translations build logging when translation is disabled#2468
kinkie wants to merge 1 commit into
squid-cache:masterfrom
kinkie:fix-translations-output-nit

Conversation

@kinkie

@kinkie kinkie commented Jul 31, 2026

Copy link
Copy Markdown
Contributor

Remove spurious \n character.

@kinkie kinkie added M-cleared-for-merge https://github.com/measurement-factory/anubis#pull-request-labels S-could-use-an-approval An approval may speed this PR merger (but is not required) backport-to-v7 maintainer has approved these changes for v7 backporting labels Jul 31, 2026
@rousskov rousskov changed the title nit: fix translations build output Fix translations build logging when translation is disabled Jul 31, 2026

@rousskov rousskov left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I adjusted PR title to be more specific and avoid introducing a nit: title prefix.

I adjusted PR description for clarity. AFAICT, it was missing a word or had a typo. The diff makes the location of this change pretty clear IMO, so we can simplify.

@yadij yadij removed the S-could-use-an-approval An approval may speed this PR merger (but is not required) label Aug 1, 2026
squid-anubis pushed a commit that referenced this pull request Aug 1, 2026
@squid-anubis squid-anubis added the M-waiting-staging-checks https://github.com/measurement-factory/anubis#pull-request-labels label Aug 1, 2026
@squid-anubis squid-anubis added M-merged https://github.com/measurement-factory/anubis#pull-request-labels and removed M-waiting-staging-checks https://github.com/measurement-factory/anubis#pull-request-labels M-cleared-for-merge https://github.com/measurement-factory/anubis#pull-request-labels labels Aug 1, 2026
@squidadm squidadm removed the backport-to-v7 maintainer has approved these changes for v7 backporting label Aug 1, 2026
@squidadm

squidadm commented Aug 1, 2026

Copy link
Copy Markdown
Collaborator

queued for backport to v7

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

M-merged https://github.com/measurement-factory/anubis#pull-request-labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants