Protect base64 username encoding buffer - #2465
Closed
kinkie wants to merge 1 commit into
Closed
Conversation
kinkie
added
backport-to-v7
rousskov
approved these changes
Jul 30, 2026
rousskov
left a comment
rousskov
left a comment
Contributor
There was a problem hiding this comment.
Thank you for squashing this bug. I hope this is the last one in this series. FWIW, I cannot find additional viable candidates.
I adjusted PR description to link this change to the recent primary commit that deals with the same problem in the rest of Squid code.
rousskov
removed
the
S-waiting-for-reviewer
Contributor
... and to mention ICAP and a related |
yadij
approved these changes
Jul 31, 2026
yadij
removed
the
S-could-use-an-approval
squid-anubis
pushed a commit
that referenced
this pull request
Jul 31, 2026
This icap_client_username_header case was missed in recent master/v8 commit 74b1276.
squid-anubis
added
the
M-waiting-staging-checks
squid-anubis
added
M-merged
squidadm
removed
the
backport-to-v7
Collaborator
|
queued for backport to v7 |
kinkie
added a commit
that referenced
this pull request
Jul 31, 2026
This icap_client_username_header case was missed in recent master/v8 commit 74b1276.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This icap_client_username_header case was missed in recent master/v8
commit 74b1276.