Repository navigation
fix(website): start the UI demo's engine in Firefox - #414
Merged
Merged
Conversation
chdb-wasm's worker hands Emscripten the downloaded wasm as bytes, and Firefox then never finishes starting the engine. The website build now has the worker stream the same blob URL, which starts in about a second in Firefox and Chrome, and names the engine directory after the patched worker too, since the engine's files are cached for good. The build fails if a chdb-wasm upgrade changes the code it replaces. The live engine panel keys its order rows by position, so an order the engine holds twice no longer breaks the list, and the cross-origin isolation test only rewrites the page's own headers instead of refetching every request.
kvlonge
enabled auto-merge (squash)
November 14, 2026 12:28
Deploying sqltide with
|
| Latest commit: |
c5fe779
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://50ebebcf.sqltide.pages.dev |
| Branch Preview URL: | https://fix-demo-firefox-engine-star.sqltide.pages.dev |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
The UI demo's real engine hangs at "Starting ClickHouse…" in Firefox most of the time. chdb-wasm's worker hands Emscripten the downloaded wasm as bytes (
wasmBinary), and Firefox never finishes starting it. Given a URL to stream instead, it starts in about a second. Separately, a build can leave an order twice in the engine, which broke the live panel's keyed list, and the cross-origin test failed when the page dropped a request it was refetching.Changes
locateFile), fails if a chdb-wasm upgrade changes that code, and hashes the patched worker into the engine directory's name, since engine files are cached as immutable.Verification
wasmBinary(4 of 4) and starts with the streamed URL (4 of 4, about 1.3 s). The rebuilt demo started 5 of 5 times, and a full click-through (every page, Plan, Execute, Promote, Roll back, recording fallback) ran with no console errors.