Repository navigation
fix(website): show the current Snowflake syntax figure and fail CI when it drifts - #246
Merged
Merged
Conversation
…en it drifts The website still showed 2,388 of 3,351 forms from 6 November. The figures are now written from the Snowflake coverage summary, and check-ci fails while website/src/data/figures.json differs from it.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
sqlquack.io, the docs coverage page and llms.txt still showed 71% (2,388 of 3,351 Snowflake forms, as of 6 November). Nobody updated
website/src/data/figures.jsonwhen the verified count rose, and nothing compared it with the coverage summary.Changes
figures.jsonnow shows 3,199 of 3,351 forms (95.46%), dated 16 November 2026.make website-figures-updatewrote these values fromsyntax-coverage summary --evidence <pinned>/syntax/snowflake --json. The summary needs--evidencebecause the cases and receipts now live in the pinned evidence repository.make website-figures, part ofcheck-ci: it fails when SYNTAX_VERIFIED, SYNTAX_FORMS or SYNTAX_PCT differ from the summary on the PR head, or when SYNTAX_BASIS does not start with the verified count.figures.jsonalone now runs the code checks, so the figure check runs on it.--evidence, and the hand-written form count is gone.Verification
make website-figuresfails on the old figures and passes on the new ones.make check-ci RECORDER=0pass on the head.