Repository navigation
fix(ci): pin DuckShop's SQLBuild to the published 0.231.0 - #242
Merged
Merged
Conversation
SQLBuild 0.187.2 is no longer published, so make duckshop-compiled could not install it and the DuckShop conversion job failed on every push, nightly and dispatched run. 0.231.0 compiles both DuckShop projects at the same revision to byte-identical output.
kvlonge
enabled auto-merge
November 15, 2026 17:30
The test named the option and all-options obligations by number, which holds only while no dialect's obligation rules are installed. When a Snowflake obligation test ran earlier in the same pytest worker, its rules renumbered the form's obligations and the test failed. It now finds the obligations by their kind.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
The DuckShop jobs install the pinned SQLBuild release from PyPI to compile DuckShop and DuckShop 10K. SQLBuild 0.187.2 is no longer published, so
make duckshop-compiledcannot resolve it and "Convert DuckShop within the time budget" fails on every push, nightly and dispatched run, including the release pull request's. Pull request and merge queue runs skip that job, which is why they stayed green.Changes
SQLBUILD_VERSIONto 0.231.0, the current SQLBuild release.SQLBUILD_REF, the DuckShop revision compiled, is unchanged.Verification
make duckshop-compiledwith 0.231.0: DuckShop compiles 412 models and DuckShop 10K 10,282 models, both with 0 errors and 0 warnings.diff -rqfinds no difference), so conversion results cannot change.make census-duckshoppasses. Converting with chained models takes 4.2 s for DuckShop and 44.3 s for DuckShop 10K, against the 300 s budget.make check-ci RECORDER=0passes.tests/unit/scriptspasses with 2 and 4 xdist workers (1,054 tests); before the fix both groupings failed the every-option test.