Skip to content

fix(ci): pin DuckShop's SQLBuild to the published 0.231.0 - #242

Merged
kvlonge merged 2 commits into
mainfrom
fix/duckshop-sqlbuild-pin
Nov 15, 2026
Merged

kvlonge merged 2 commits into
mainfrom
fix/duckshop-sqlbuild-pin

Conversation

@kvlonge

@kvlonge kvlonge commented Nov 15, 2026 •

Copy link
Copy Markdown
Contributor

Why

The DuckShop jobs install the pinned SQLBuild release from PyPI to compile DuckShop and DuckShop 10K. SQLBuild 0.187.2 is no longer published, so make duckshop-compiled cannot resolve it and "Convert DuckShop within the time budget" fails on every push, nightly and dispatched run, including the release pull request's. Pull request and merge queue runs skip that job, which is why they stayed green.

Changes

  • Pin SQLBUILD_VERSION to 0.231.0, the current SQLBuild release. SQLBUILD_REF, the DuckShop revision compiled, is unchanged.
  • The every-option case test finds its obligations by kind, not by number. The numbers changed when a Snowflake obligation test ran earlier in the same pytest worker, which failed this pull request's first CI run.

Verification

  • make duckshop-compiled with 0.231.0: DuckShop compiles 412 models and DuckShop 10K 10,282 models, both with 0 errors and 0 warnings.
  • The compiled output of both projects is byte-identical to 0.187.2's at the same revision (2,427 and 43,100 files, diff -rq finds no difference), so conversion results cannot change.
  • make census-duckshop passes. Converting with chained models takes 4.2 s for DuckShop and 44.3 s for DuckShop 10K, against the 300 s budget.
  • make check-ci RECORDER=0 passes.
  • tests/unit/scripts passes with 2 and 4 xdist workers (1,054 tests); before the fix both groupings failed the every-option test.

SQLBuild 0.187.2 is no longer published, so make duckshop-compiled could
not install it and the DuckShop conversion job failed on every push,
nightly and dispatched run. 0.231.0 compiles both DuckShop projects at the
same revision to byte-identical output.
@kvlonge
kvlonge enabled auto-merge November 15, 2026 17:30
The test named the option and all-options obligations by number, which
holds only while no dialect's obligation rules are installed. When a
Snowflake obligation test ran earlier in the same pytest worker, its rules
renumbered the form's obligations and the test failed. It now finds the
obligations by their kind.
@kvlonge
kvlonge added this pull request to the merge queue Nov 15, 2026
Merged via the queue into main with commit 04d0b6c Nov 15, 2026
10 checks passed
@kvlonge
kvlonge deleted the fix/duckshop-sqlbuild-pin branch November 15, 2026 19:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant