Repository navigation
fix(syntax-snowflake): parse a call that leaves out its schema as a qualified call - #230
Merged
Merged
Conversation
…ualified call Snowflake's `<database>..<function>( ... )` now parses into the qualified call node with the name `[database, null, function]`, instead of a method call on a column that named the database. Spelling keys keep the empty part. Lineage reads only the arguments of a Snowflake schema-qualified call, so its qualifier is never traced as a column, and both spellings trace alike. The converter still refuses the call.
… trees changed The 235 verified forms with a call that leaves out its schema were read again for their changed trees only: each call is now a qualified call whose name keeps the omitted schema as null, with its arguments unchanged. All are approved; the baseline is re-recorded.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Snowflake's
<database>..<function>( ... )leaves the schema out. The parser stored it as a method call on a column that named the database, with a flag marking the omitted schema. That claims the database is a column and puts the name in a different place from every other qualified call. It should ship as a qualified call before the next release.Changes
db..f( ... )now parses into the qualified call node, with name[db, null, f], and keeps its arguments. The method call loses itsschema_omittedflag.db.s.f( ... )stays a method call.SNOWFLAKE..NULL_COUNTkeeps its three-part key.<schema>.<function>( ... )call, so the qualifier is no longer traced as a column.db..f(x)anddb.s.f(x)now trace the same way.db..f( ... ). No schema is guessed.Verification
make check-cipasses.