Repository navigation
feat(syntax): structure Snowflake EXECUTE IMMEDIATE and verify 288 more forms - #221
Merged
Merged
Conversation
EXECUTE IMMEDIATE was kept as opaque command text. It now parses into an ExecuteImmediate node: the source (a string, a bound or session variable, a variable name, or a || concatenation of them, or the location after FROM), the USING variables or named arguments, and DRY_RUN. It ends at the statement end or before a ) closing an enclosing assignment, so a RESULTSET and a plain := assignment can take it in parentheses.
…d ALTER WAREHOUSE IF EXISTS A notebook may be named PROJECT when a property assignment follows its name, as in CREATE NOTEBOOK project QUERY_WAREHOUSE = w1. ALTER WAREHOUSE IF EXISTS with no name now refuses the actions that need a name, as the unnamed form already did.
…ake SHOW as a name Snowflake reads SHOW TABLES IN APPLICATION ; and SHOW GRANTS TO ROLE ; as naming a schema or grantee called APPLICATION or ROLE. They answer the errors IN v1 and TO v1 answer, not the ones a named container gives, and the kinds that take no plain name refuse the bare word. The tree now names the word instead of recording a container kind with no name.
…ke forms Each form was read against its documentation page, obligations, cases and parse trees by a reviewer other than the parser's author, and is bound to its fingerprint and definition. 288 forms become verified (2,421 to 2,709); 41 reviewed forms were rejected and stay unverified.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
930 Snowflake forms were unverified; most needed only an independent review, and EXECUTE IMMEDIATE was an opaque command no obligation accepts.
Changes
;or before), sor := ( ... )works.CREATE NOTEBOOK project QUERY_WAREHOUSE = ...parses; ALTER WAREHOUSE IF EXISTS with no name refuses ADD/DROP, RENAME and TAG.GRANTS TO|OF, as a name. Snowflake answersIN CLASS ;asIN v1(2003), not asIN CLASS v1(398014).Verification
make check-cipasses on the final head.