Repository navigation
fix(syntax): follow recorded verdicts on privileges, variables, warehouses, RESULTSET assignments and SHOW SERVICES - #219
Merged
Merged
Conversation
A SHOW privilege list now names the privileges a GRANT takes, each followed by a comma or the statement end, so a plain name is refused as the recorded receipts show.
A variable needs an unquoted type after its name, DEFAULT needs a value and COMMENT takes a string, as the recorded receipts show.
A DESCRIBE argument may not open with a bare parenthesis, and a TABLE argument needs at least one column type, as the recorded receipts show.
…connector PUSH ALTER WAREHOUSE ADD and DROP take TABLES and a list of named tables, ABORT needs ALL QUERIES, the current warehouse cannot add or drop tables, rename or tag itself, and UNSET takes names, not strings. An Openflow connector pushes to a location string, as the recorded receipts show.
An event table takes the table properties after its name except WITH CONTACT, as the recorded receipts show.
…, warehouse and event table fixes cleared The receipt disagreements fall from 618 to 583 entries, none added.
…TE, notebook name, event table contact and SHOW SERVICES questions
…ATE, notebook name, event table contact and SHOW SERVICES questions
…RVICES verdicts An EXECUTE IMMEDIATE inside a parenthesised RESULTSET assignment now ends before the closing parenthesis, so LET can take it. A notebook may be named PROJECT when its name ends the statement or FROM follows. SHOW SERVICES reads OF TYPE straight after the kind, where Snowflake accepts it, and refuses it after IN.
…SHOW SERVICES fixes cleared Every receipt of the batch agrees with the parser, so the disagreement list stays at 583 entries, and four event table and SHOW SERVICES obligations are now met. The RESULTSET assignment form loses its approval: its two new EXECUTE IMMEDIATE cases parse, but EXECUTE IMMEDIATE is still kept as an opaque command, which no positive obligation accepts, until it has a structured node.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Recorded Snowflake verdicts disagreed with the parser on more statements, including the RESULTSET, notebook and SHOW SERVICES questions left open by the last parser change. Each fix follows a receipt, and the disagreements list only shrinks.
Changes
TABLE ( )is refused.LET r RESULTSET := ( EXECUTE IMMEDIATE :q [ USING ( ... ) ] )parses: the command ends before the closing parenthesis.CREATE NOTEBOOK project [FROM ...]from accepted to refused; Snowflake parses it, so this restores it.Verification
fensu checkpass.make check-cipasses on the final head.