Repository navigation
fix(syntax): read more Snowflake object statements as the receipts record - #218
Merged
Merged
Conversation
… and DEFINE of tags, pipes and code bundles as Snowflake does ALTER EXTERNAL CONSUMER takes its token actions and SET and UNSET, and CREATE EXTERNAL CONSUMER keeps its kind. CREATE AI FUNCTION is checked as the CREATE FUNCTION it mirrors, and a function may come FROM EXPERIMENT <name> RUN <name>. EXECUTE IMMEDIATE checks its source, its USING list and FROM's arguments and DRY_RUN. DEFINE takes a tag, pipe or code bundle, a pipe's body is AS COPY, and a code bundle needs FROM.
…n, EXECUTE IMMEDIATE and DEFINE fixes cleared
…name properties as Snowflake does CREATE NOTEBOOK PROJECT needs FROM and may leave out its database, and PROJECT alone is no kind. CREATE ORGANIZATION PROFILE takes an AS manifest string or a FROM stage path with a named VERSION, then PUBLISH. A failover or replication group refuses a string as a value that names objects, and a quoted integration type.
…ORMAT modifiers SHOW SERVICES now takes the Snowflake SHOW clauses with EXCLUDE JOBS, OF TYPE and IN COMPUTE POOL. CREATE SNAPSHOT needs FROM SERVICE, VOLUME and INSTANCE before its options, and DEFINE FILE FORMAT refuses TEMPORARY, TEMP and VOLATILE, as the recorded receipts show.
…licy or tag ALTER USER may still leave the name out to set or unset properties, reset the password, abort queries or manage credentials, as the recorded receipts show, but Snowflake refuses RENAME TO, ENROLL MFA and SET or UNSET of a policy or tag without one.
…and user fixes cleared The receipt disagreements fall from 746 to 646 entries, none added, and the baseline is snapshotted against the same pinned evidence.
…ts and organization user groups CREATE EXTERNAL AGENT keeps EXTERNAL in its text and takes only WITH VERSION after its name. An Openflow connector adds a version from a location string or a live version from LAST. SHOW TASKS takes ROOT ONLY after STARTS WITH, and ORGANIZATION USER GROUP is a property-only kind, as the recorded receipts show.
…sk and user group fixes cleared The receipt disagreements fall from 646 to 618 entries, none added.
…INE in DEFINE text EXECUTE IMMEDIATE takes a :bound variable and a || concatenation of strings and variables, as Snowflake documents. A DEFINE kept as text now says DEFINE rather than CREATE, and SHOW SERVICES reads OF TYPE as a list after LIMIT, where the documented grammar places it.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Recorded Snowflake verdicts disagreed with the parser on more object statements. Each fix follows a receipt, and the disagreements list only shrinks.
Changes
FROM EXPERIMENT <name> RUN <name>.$or:variable, or a||concatenation of them.Verification
fensu checkpass.make check-cipasses on the final head.