Skip to content

ci(syntax-coverage): fail the gate when Snowflake obligations are stale - #213

Merged
kvlonge merged 3 commits into
mainfrom
fix/obligations-drift
Nov 13, 2026
Merged

kvlonge merged 3 commits into
mainfrom
fix/obligations-drift

Conversation

@kvlonge

@kvlonge kvlonge commented Nov 12, 2026

Copy link
Copy Markdown
Contributor

Why

The Snowflake obligations builder had no check mode, so stale generated files went unnoticed. A limits.toml edit that corrected two documented DDL cases landed without a rebuild, leaving 21 derived rejections (19 Iceberg REST catalog-linked, 2 semantic view) that the corrected cases also accept; none was satisfied.

Changes

  • The DDL family is rebuilt: those 21 rejections move to withdrawn/ddl.toml.
  • build_syntax_obligations_snowflake --check writes nothing and fails on each obligations, withdrawn or elisions file the build would write differently; regeneration is unchanged.
  • --since REV builds only the families whose inputs changed since the merge base with REV:
    • a builder change selects every family;
    • a family's catalogue, obligations, withdrawn or elisions file selects that family, and a catalogue change also selects the elision families;
    • a limits.toml edit selects only the families whose rows differ.
  • make syntax-obligations, in check-ci, runs --check --since against the pull request's base and passes with every family skipped when none changed.
  • The nightly run checks every family; a failed nightly run opens an issue labelled nightly-ci-failure or comments on the open one.

Verification

  • Every family checked: 0 stale files, about 100 s. With no change since the base all 10 are skipped and the step passes; an unknown base fails it.
  • Before the rebuild, the old withdrawn/ddl.toml fails --check.
  • Tests:
    • A stale or missing withdrawn, obligations or elisions file fails the check.
    • Selection is correct on a branch that is behind its base.
    • The builder imports only paths that select every family.
    • Mutants that drop elisions, ignore committed changes or compare with the base's tip fail them.
  • The baseline is byte-identical and make syntax-cases passes; no evidence publish needed.
  • The nightly report step ran against a stub gh on both branches; actionlint passes.
  • make check-ci passed.

…umented cases also accept

Correcting the documented Iceberg PARTITION BY and semantic view
REFERENCES rows made 21 rejection obligations render SQL an accepted row
also renders, but the DDL obligations were not rebuilt. Rebuilding them
withdraws those 21; none was satisfied, so coverage is unchanged.
The Snowflake obligations builder had no --check, so a limits.toml edit
that changed a family's withdrawals could land without regenerating them.
The builder now takes --check, which writes nothing and fails on each
obligations, withdrawn or elisions file that differs from what it would
write, and --since, which builds only the families whose catalogue, rows
in limits.toml, generated files or builder changed since a revision.
make syntax-obligations runs both against EVIDENCE_BASE as part of
check-ci, and passes when no family changed.
…led nightly runs

Pull requests and queue groups check only the families their change
touches, so a scheduled run, whose base is the commit it tests, checked
none. SYNTAX_OBLIGATIONS_SINCE, empty outside pull requests and queue
groups, now makes those runs check every family. A failed scheduled run
opens an issue labelled nightly-ci-failure, or comments on the open one.
@kvlonge
kvlonge enabled auto-merge November 12, 2026 23:56
@kvlonge
kvlonge added this pull request to the merge queue Nov 13, 2026
Merged via the queue into main with commit 1472333 Nov 13, 2026
14 checks passed
@kvlonge
kvlonge deleted the fix/obligations-drift branch November 13, 2026 00:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant