Repository navigation
ci(syntax-coverage): fail the gate when Snowflake obligations are stale - #213
Merged
Merged
Conversation
…umented cases also accept Correcting the documented Iceberg PARTITION BY and semantic view REFERENCES rows made 21 rejection obligations render SQL an accepted row also renders, but the DDL obligations were not rebuilt. Rebuilding them withdraws those 21; none was satisfied, so coverage is unchanged.
The Snowflake obligations builder had no --check, so a limits.toml edit that changed a family's withdrawals could land without regenerating them. The builder now takes --check, which writes nothing and fails on each obligations, withdrawn or elisions file that differs from what it would write, and --since, which builds only the families whose catalogue, rows in limits.toml, generated files or builder changed since a revision. make syntax-obligations runs both against EVIDENCE_BASE as part of check-ci, and passes when no family changed.
…led nightly runs Pull requests and queue groups check only the families their change touches, so a scheduled run, whose base is the commit it tests, checked none. SYNTAX_OBLIGATIONS_SINCE, empty outside pull requests and queue groups, now makes those runs check every family. A failed scheduled run opens an issue labelled nightly-ci-failure, or comments on the open one.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
The Snowflake obligations builder had no check mode, so stale generated files went unnoticed. A
limits.tomledit that corrected two documented DDL cases landed without a rebuild, leaving 21 derived rejections (19 Iceberg REST catalog-linked, 2 semantic view) that the corrected cases also accept; none was satisfied.Changes
withdrawn/ddl.toml.build_syntax_obligations_snowflake --checkwrites nothing and fails on each obligations, withdrawn or elisions file the build would write differently; regeneration is unchanged.--since REVbuilds only the families whose inputs changed since the merge base with REV:limits.tomledit selects only the families whose rows differ.make syntax-obligations, incheck-ci, runs--check --sinceagainst the pull request's base and passes with every family skipped when none changed.nightly-ci-failureor comments on the open one.Verification
withdrawn/ddl.tomlfails--check.make syntax-casespasses; no evidence publish needed.ghon both branches; actionlint passes.make check-cipassed.