Repository navigation
fix(lint): read a FIRST or LAST join alias as the relation alias - #212
Merged
Merged
Conversation
Snowflake reads a bare FIRST or LAST after a joined table as its alias, which the parser accepts since 0.11.0. The lint's token path only took identifier tokens as aliases and qualifiers, so for JOIN t first ON ..., LEFT JOIN t last USING (...) and CROSS JOIN t first it took the table name as the alias and reported SQLCLEAN032 although first.x is selected, and it reported SQLCLEAN022 for first.x as an unnamed calculation.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Since 0.11.0 the Snowflake parser reads a bare FIRST or LAST after a joined table as that relation's alias. The lint's token path still took only identifier tokens as aliases and qualifiers. For
JOIN t first ON …,LEFT JOIN t last USING (…)andCROSS JOIN t first, it therefore took the table name as the alias and reported SQLCLEAN032 ("Joined relation contributes no referenced values") althoughfirst.xis selected. CROSS JOIN also reported SQLCLEAN022 forfirst.x. The same statements with ordinary aliases reported neither.Changes
first.* EXCLUDE (…)for SQLCLEAN022), a control with an ordinary alias, and a LAST alias that is really unused, which still reports SQLCLEAN032 on the JOIN.Verification
fandl.cargo test -p sqlquack-lintpasses.make check-cipassed.