Repository navigation
feat(snowflake): Databricks and ClickHouse read a Snowflake S3 unload themselves - #346
Merged
Merged
Conversation
…nless masks or a time column need SQLLoad
…estamps from microseconds
…er file, rows checked against the unload
…tion into a staging table; an unload outside every location fails plan
… folder covers it; each unload is its own batch so merge ordinals stay unique across windows
…ts merge row numbers fit 64 bits
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A Snowflake source with a stage
urlin S3 now loads into Databricks and ClickHouse without any row passing through SQLLoad, as it already did into DuckDB.COPYs the files Snowflake unloads through the Unity Catalog external location that covers theurl, into a staging or build table (anappendtoo). A batch publishes only when theCOPYs load as many rows as Snowflake reported unloading.s3()into the load's staging table, signed with the same S3 credentials as SQLLoad, and publishes only when it loads as many rows as were unloaded.planshows the route (unload Parquet to s3://…/ -> Databricks COPY INTO (nothing through the loader)). A table with aTIMEcolumn or amaskstays on SQLLoad's reader, andplansays why.plan, asking for a largerbatch_size./, so an external location over exactly that folder covers it.BREAKING CHANGE: a Snowflake S3 unload into Databricks that no external location covers now fails
planwith the fix, instead of loading through SQLLoad. A Snowflake table read through an unload is limited to 32,767 cursor windows.Testing
make verifyandmake test-pythonpass on this head.urloutside every location failsplanwith the fix, and the unload folder is empty afterwards. Merge loads across windows: 99 stale keys before the batch fix, 0 after.