Repository navigation
feat!: replace @task with @asset as the one Python node - #1611
Merged
Merged
Conversation
Work in progress, paused for a higher priority. Adds two cases to the compile layout E2E test: a node module importing sqlbuild.tasks (the decorator, and the module with TaskContext) must fail compile and say to use @asset from sqlbuild.assets. Run locally against main's build: both cases fail, because compile still accepts @task. The removal itself is not started. Plan when resumed: after sqlbuild.tasks is deleted, compile already fails with D011 'No module named sqlbuild.tasks'; add the @asset guidance where ProjectDir::load imports node files (python-front imported_modules.rs), then remove the task kind from Rust, Python, UI, docs, templates and skill references.
Work in progress, not ready for review. Removes sqlbuild.tasks, @task, TaskContext and the task node kind from discovery, records, compile, selection, planning, rules, the UI selector list and the Python nodes playground (its upstream examples are now assets). Importing sqlbuild.tasks from a node file now fails compile with a message that points to @asset from sqlbuild.assets. Readers of data written by older versions keep accepting the task kind: the integration-result contract, published snapshots in orchestration, change labels for a previous definition snapshot, and UI display maps. Validated so far: cargo check of the workspace with all targets, the UI unit tests (625 passed), and the Python unit suite except about 60 discovery, executor and output tests whose expectations still list task and asset nodes separately. Docs are not updated yet.
Unit suite passes (9382). Removes the materialized check that only rejected tasks, the task-only decorator, context and result tests, and re-records the two identity-sharing digests, whose only change is the node type (verified: with kind=task they reproduce the old digests).
Rust and Python expectations now name assets, selection orders follow the asset sort order, the explicit-reference golden is re-recorded (each changed digest reproduces the old one with the task wording restored), the docs drop tasks, and the docs skill references are regenerated. Validation so far: cargo test of the touched crates passes apart from a launcher SIGINT test that fails in this sandbox only; make test has 4 remaining failures from a stale local sqlbuild version (env-only); fensu check clean.
…sages Keep python_task in the lifecycle operation catalogue as a retired name so history written by earlier versions still decodes. Remove task from the remaining validation and executor messages, and regenerate the compiler goldens that carried the old wording.
kvlonge
enabled auto-merge
November 20, 2026 23:32
github-merge-queue
Bot
removed this pull request from the merge queue due to failed status checks
Nov 21, 2026
The end-to-end shards still asserted task labels, kind ordering and decorators that no longer exist. They now assert the same behavior against @asset nodes.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
@taskand@assetdid the same job: dependencies, SQL reads, retries, skips and results were identical, and assets only added optional output metadata (columns,column_lineage,materialized). Users picked one by feel. SQLBuild now has one Python node for computation and side effects:@asset. Loaders and checks stay separate kinds.Changes
@task,sqlbuild.tasks,TaskContextand thetasknode kind outright. Importingsqlbuild.tasksfails compile with a message that says to use@assetfromsqlbuild.assetswithAssetContext.taskfrom the kind tables in planning publications, integration results and definition-change labels, from progress output, and from validation messages.python_taskstays in the lifecycle catalogue as a retired name, so history from earlier versions still reads back insqb recall.@asset. The Assets page says that, for users coming from task-based tools, an asset is a task that may not describe its output. The playground template uses an asset.task:identities are not mapped. Nodes that were tasks start as new assets.BREAKING CHANGE:
@task,sqlbuild.tasksandTaskContextare removed. Use@assetfromsqlbuild.assetsandAssetContext. Thetasknode kind and thetask:selector no longer exist.Verification
sqlbuild.tasksand expects the@assetmessage; it fails on main.make testandmake check-cion the final head.