Repository navigation
refactor(analysis): export the shared call depth from the compile bindings - #1599
Merged
Merged
Conversation
…dings The Python bindings crate is at its code-line cap, so the analysis registration in sqlbuild-python-compile exports MAX_FUNCTION_CALL_DEPTH to sqlbuild._native instead of the bindings crate's constant table.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
#1596 added
MAX_FUNCTION_CALL_DEPTHto the Python bindings crate's constant table. That crate is held at a code-line cap, and those two lines push it over the cap once other queued changes land.Changes
sqlbuild-python-compileexportsMAX_FUNCTION_CALL_DEPTHtosqlbuild._native; the bindings crate's constant table no longer lists it. Python reads the same name from the same module, so nothing else changes.Verification
make check-ci(fensu, native stub check, cargo and clippy) on this tree.sqlbuild.compiler.sql_analysis.constants.POLYGLOT_MAX_FUNCTION_CALL_DEPTHstill reads 256 from the native module.