Skip to content

refactor(analysis): export the shared call depth from the compile bindings - #1599

Merged
kvlonge merged 1 commit into
mainfrom
refactor/call-depth-constant-export
Nov 19, 2026
Merged

kvlonge merged 1 commit into
mainfrom
refactor/call-depth-constant-export

Conversation

@kvlonge

@kvlonge kvlonge commented Nov 19, 2026

Copy link
Copy Markdown
Contributor

Why

#1596 added MAX_FUNCTION_CALL_DEPTH to the Python bindings crate's constant table. That crate is held at a code-line cap, and those two lines push it over the cap once other queued changes land.

Changes

  • The analysis registration in sqlbuild-python-compile exports MAX_FUNCTION_CALL_DEPTH to sqlbuild._native; the bindings crate's constant table no longer lists it. Python reads the same name from the same module, so nothing else changes.

Verification

  • make check-ci (fensu, native stub check, cargo and clippy) on this tree.
  • sqlbuild.compiler.sql_analysis.constants.POLYGLOT_MAX_FUNCTION_CALL_DEPTH still reads 256 from the native module.

…dings

The Python bindings crate is at its code-line cap, so the analysis
registration in sqlbuild-python-compile exports MAX_FUNCTION_CALL_DEPTH
to sqlbuild._native instead of the bindings crate's constant table.
@kvlonge
kvlonge enabled auto-merge November 19, 2026 15:42
@kvlonge
kvlonge added this pull request to the merge queue Nov 19, 2026
Merged via the queue into main with commit e395c21 Nov 19, 2026
33 checks passed
@kvlonge
kvlonge deleted the refactor/call-depth-constant-export branch November 19, 2026 16:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant