Repository navigation
refactor(api): keep plan diffs in one place and drop unwatched node-state views - #1588
Merged
Merged
Conversation
A location always detaches model diff text and the server reads a diff only from where it stored it, so the inline lookup and the copied diff type go.
…by snapshot The node states cache kept refreshing every target anyone had read for the life of the server. A change stream now holds its target watched while it is open; a store signal refreshes watched targets and drops the others, which the next read loads again. The node list no longer embeds states, which node-states serves, so it is serialized once per snapshot and its ETag is the snapshot ID: a build no longer invalidates it.
SnapshotSlots and cached only ever held prepared publications, so they name CachedPublication instead of a type parameter.
The node list no longer carries states, so the catalog keeps the states it holds while the list and states are read again, and a node page or overview opened without the held list reads the states with it. The server keeps a dropped target's entry while a refresh is still pending, so the refresh cannot push the old entry's versions to a new stream.
…artial overview once A refresh that finds its target changed again runs another pass, so the entry stays held while one is due as well as while one is scheduled. A read without the held node list asks for the states only once the list is allowed, so a partial viewer's refusal is recorded once.
kvlonge
enabled auto-merge
November 18, 2026 22:27
… tests The node list no longer carries states, so the catalog-read and check-count tests read them from node-states as clients do. The wide-listing statement guard still counts the node list alone, within its unchanged budget.
github-merge-queue
Bot
removed this pull request from the merge queue due to a conflict with the base branch
Nov 18, 2026
…ode-states # Conflicts: # crates/sqlbuild-orchestration/src/warehouse_metadata/models.rs
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Plan diffs lived in two places, the node-states cache refreshed every target anyone had read for the life of the server, a build invalidated the node list's ETag, and the publication cache was generic over the one type it held.
Changes
/nodesno longer embeds states, which/node-statesserves. It is serialized once per snapshot and tagged with the snapshot ID.Plans stored with diffs inside the document show line counts without diff text until they expire.
Verification
make check-cion the final head.