Repository navigation
refactor(location): drop old-server fallbacks and duplicate sync state - #1587
Merged
Merged
Conversation
- Sync-due replies carry the server's state-history limit; the retention endpoint and its client call are gone. - Preview copies are always versioned: no `versioned` flag, no unversioned retry, and `version` is always present. - A stopped sync resumed by a run, the timed sync or a request backs off again from a fresh failure count. - A busy warehouse file is read from the failure itself, the page timeout is a constant, and a reader that did not start reports a read error. - The timed sync never wakes billed compute, whether or not the interval was set. - Mirrored record counts come from the sync: the server counts a table after its read's last page and the location reports it, replacing the per-page-load count endpoint.
A table the warehouse reports unchanged is skipped without delivery, so it reported no mirrored count and its total dropped out of the connections page once older reports aged out. The recorded change token now keeps the count from the read that recorded it, and the skipped read reports it again. Regenerate the server docs reference.
…kind The server counts a kind's mirror across every state location, so a read of the same kind in another location replaces the count a skipped table repeats. Without this, a skipped table could report an older total than the read before it.
kvlonge
enabled auto-merge
November 18, 2026 21:44
# Conflicts: # crates/sqlbuild-cli/src/native_commands/models.rs # crates/sqlbuild-cli/src/native_commands/tests/test_types.rs # crates/sqlbuild-orchestration/src/warehouse_metadata/_helpers/ingestion.rs
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
The location sync carried fallbacks for older servers and state that duplicated other state. There are no external users yet and the server upgrades first, so the fallbacks go. The connections page also counted 14 mirror tables on every load to show mirrored totals.
Changes
busycomes from the read failure, the page time is a constant, and the reader-start read failure is folded into the read error./mirrored-totalsendpoint is removed.Upgrade note: a location older than this server cannot decode the new sync-due reply, so upgrade locations with the server. Health events of the removed reader-start kind written in the last 7 days no longer decode.
Verification
sqlbuild-clilocation metadata, sync schedule and changed-build tests.make check-cion the final head.