Skip to content

feat(plan)!: list a run's ignored audit failures and finish the paged plan sections - #1573

Merged
kvlonge merged 8 commits into
mainfrom
feat/plan-leftovers
Nov 18, 2026
Merged

kvlonge merged 8 commits into
mainfrom
feat/plan-leftovers

Conversation

@kvlonge

@kvlonge kvlonge commented Nov 18, 2026 •

Copy link
Copy Markdown
Contributor

Why

The paged plan page worked around gaps in the summary: one seeds section, a diff read per row for small config changes, warnings grouped in the browser, and a --changed Checks tab listing skipped nodes. The run page found ignored audit failures by filtering checks, missing any a later run replaced.

Changes

  • Plan summary and pages: seeds split into first_run_seeds, changed_seeds and unchanged_seeds; model rows carry config_change for small top-level config changes, also when diffs are stored apart, redacted like them; the summary lists the 50 largest warning_groups and pages every warning in that order. The seeds section value is gone: send first_run_seeds, changed_seeds or unchanged_seeds instead.
  • New person endpoint GET …/runs/{run_id}/ignored-audits: every ignored audit failure of a run and its current group members (audit, model, column, severity, violations), authorized like the run's statements.
  • UI: the plan page uses the seed sections, the server's config changes and warning groups (a group's warnings are read when it opens; warnings past the listed groups read as one more group). The Checks tab under --changed leaves out held-back and unchanged nodes, read when the tab opens. The ignored-audits panel reads the new endpoint and links to the Checks page for failures it can no longer list.

No DuckShop case: plan display and API reads, not a project shape.

Verification

  • cargo test -p sqlbuild-core plan_display: seed split, config changes (nested keys and moved commas are not changes), warning groups, and a 10,000-model --changed summary with distinct warnings staying under 16 KB.
  • Orchestration tests on SQLite and PostgreSQL: group members' ignored audits; config changes survive detaching and are redacted without view.sql.
  • Vitest, svelte-check, and Playwright plan-browser and ignored-audits specs, including warning reads across page loads and --changed checks.
  • make check-ci on the final head.

… sections

Work in progress: seeds split by reason, a per-row config change, warnings
grouped by the server, the nodes --changed runs, and a person endpoint for the
audit failures a run and its group members let through.
The summary no longer lists the nodes --changed runs, and lists at most
the 50 largest warning groups; the warnings section pages the rest after
them, which the plan page shows as one more group. The Checks tab reads
what --changed skips from the held-back and unchanged pages when it
opens.

A config change line reads only top-level keys and leaves out keys whose
value is unchanged, so a nested key or a moved trailing comma no longer
reads as a change.

An open warning group keeps the warnings it read while other sections
load pages, reads each page once, and drops a read another plan
replaced. The ignored-audits panel links to the Checks page when it
lists fewer failures than the run counts.
…hort

Warning groups are keyed by where their warnings start, so a template
that repeats the rest group's name cannot merge two groups. A new plan
closes every group. Showing all of a group larger than one read says how
many of its warnings are listed. The Checks tab says when it cannot read
the nodes --changed skips instead of reading forever, and the
ignored-audits panel counts the failures it no longer lists without a
plural slip.
The run events, statements and ignored-audit reads each opened the run's
Recall transaction, read and committed. They now hand their read to one
helper beside the sensitive run read, and keep only their own call.
@kvlonge
kvlonge enabled auto-merge November 18, 2026 10:10
@kvlonge
kvlonge added this pull request to the merge queue Nov 18, 2026
Merged via the queue into main with commit 49cddc7 Nov 18, 2026
36 checks passed
@kvlonge
kvlonge deleted the feat/plan-leftovers branch November 18, 2026 11:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant