Repository navigation
feat(plan)!: list a run's ignored audit failures and finish the paged plan sections - #1573
Merged
Merged
Conversation
… sections Work in progress: seeds split by reason, a per-row config change, warnings grouped by the server, the nodes --changed runs, and a person endpoint for the audit failures a run and its group members let through.
The summary no longer lists the nodes --changed runs, and lists at most the 50 largest warning groups; the warnings section pages the rest after them, which the plan page shows as one more group. The Checks tab reads what --changed skips from the held-back and unchanged pages when it opens. A config change line reads only top-level keys and leaves out keys whose value is unchanged, so a nested key or a moved trailing comma no longer reads as a change. An open warning group keeps the warnings it read while other sections load pages, reads each page once, and drops a read another plan replaced. The ignored-audits panel links to the Checks page when it lists fewer failures than the run counts.
…hort Warning groups are keyed by where their warnings start, so a template that repeats the rest group's name cannot merge two groups. A new plan closes every group. Showing all of a group larger than one read says how many of its warnings are listed. The Checks tab says when it cannot read the nodes --changed skips instead of reading forever, and the ignored-audits panel counts the failures it no longer lists without a plural slip.
The run events, statements and ignored-audit reads each opened the run's Recall transaction, read and committed. They now hand their read to one helper beside the sensitive run read, and keep only their own call.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
The paged plan page worked around gaps in the summary: one seeds section, a diff read per row for small config changes, warnings grouped in the browser, and a
--changedChecks tab listing skipped nodes. The run page found ignored audit failures by filtering checks, missing any a later run replaced.Changes
first_run_seeds,changed_seedsandunchanged_seeds; model rows carryconfig_changefor small top-level config changes, also when diffs are stored apart, redacted like them; the summary lists the 50 largestwarning_groupsand pages every warning in that order. Theseedssection value is gone: sendfirst_run_seeds,changed_seedsorunchanged_seedsinstead.GET …/runs/{run_id}/ignored-audits: every ignored audit failure of a run and its current group members (audit, model, column, severity, violations), authorized like the run's statements.--changedleaves out held-back and unchanged nodes, read when the tab opens. The ignored-audits panel reads the new endpoint and links to the Checks page for failures it can no longer list.No DuckShop case: plan display and API reads, not a project shape.
Verification
cargo test -p sqlbuild-core plan_display: seed split, config changes (nested keys and moved commas are not changes), warning groups, and a 10,000-model--changedsummary with distinct warnings staying under 16 KB.plan-browserandignored-auditsspecs, including warning reads across page loads and--changedchecks.make check-cion the final head.