Repository navigation
test(location): show the location log when a replan report is wrong - #1570
Merged
Merged
Conversation
The replan-after-sync check failed once in CI with every model reported changed after a rebuild and a requested sync, and the failure carried no log. Include the location log in both report assertions so a recurrence shows which sync the plan followed and what each sync read.
kvlonge
marked this pull request as ready for review
November 18, 2026 09:59
kvlonge
enabled auto-merge
November 18, 2026 09:59
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
The replan-after-sync integration check failed once in CI: after a rebuild and a requested sync, every model was reported changed. The assertion carried no log, so the run could not show which sync the plan followed. Local runs (55 of 55) passed, and the code has a single inline writer, so overlapping replans are ruled out. The remaining candidate is a sync that reads before the build's history is written. That would be a product bug to fix on the read side, so the test should not be loosened.
Changes
test_plan_preview.pynow print the location log on failure, so a recurrence shows which sync each plan followed and what each sync read.Verification