Skip to content

test(location): show the location log when a replan report is wrong - #1570

Merged
kvlonge merged 1 commit into
mainfrom
test/replan-report-evidence
Nov 18, 2026
Merged

kvlonge merged 1 commit into
mainfrom
test/replan-report-evidence

Conversation

@kvlonge

@kvlonge kvlonge commented Nov 18, 2026

Copy link
Copy Markdown
Contributor

Why

The replan-after-sync integration check failed once in CI: after a rebuild and a requested sync, every model was reported changed. The assertion carried no log, so the run could not show which sync the plan followed. Local runs (55 of 55) passed, and the code has a single inline writer, so overlapping replans are ruled out. The remaining candidate is a sync that reads before the build's history is written. That would be a product bug to fix on the read side, so the test should not be loosened.

Changes

  • Both report assertions in test_plan_preview.py now print the location log on failure, so a recurrence shows which sync each plan followed and what each sync read.

Verification

  • The replan test passes locally against main.
  • Command-line and test-diagnostics only: there is no project shape, data value or lifecycle sequence to add to DuckShop.

The replan-after-sync check failed once in CI with every model reported
changed after a rebuild and a requested sync, and the failure carried no
log. Include the location log in both report assertions so a recurrence
shows which sync the plan followed and what each sync read.
@kvlonge
kvlonge marked this pull request as ready for review November 18, 2026 09:59
@kvlonge
kvlonge enabled auto-merge November 18, 2026 09:59
@kvlonge
kvlonge added this pull request to the merge queue Nov 18, 2026
Merged via the queue into main with commit a341abb Nov 18, 2026
62 checks passed
@kvlonge
kvlonge deleted the test/replan-report-evidence branch November 18, 2026 10:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant