Skip to content

test(recall): keep writer test sessions inside the retention window - #1564

Merged
kvlonge merged 1 commit into
mainfrom
test/recall-fixture-retention
Nov 18, 2026
Merged

kvlonge merged 1 commit into
mainfrom
test/recall-fixture-retention

Conversation

@kvlonge

@kvlonge kvlonge commented Nov 18, 2026

Copy link
Copy Markdown
Contributor

Why

Since 00:00 UTC on 2026-11-18, five sqlbuild-recall writer tests fail on main and on every branch, so the "Native workspace checks" job fails for every pull request and in the merge queue. The writer test fixtures stamp invocations with a fixed date, 2026-10-19, and their sessions run retention maintenance with a 30-day window. Once that date became older than 30 days, maintenance pruned the rows the tests read back.

Changes

  • The writer test session configuration uses a retention window that the fixed fixture timestamps never leave. Maintenance still runs in these sessions and prunes nothing.
  • No product code changes.

Verification

  • On main, cargo test -p sqlbuild-recall --lib fails 5 of 69 tests (the session and artifact writer tests); with this change, all 69 pass.
  • make check-ci passes on this head.

The writer test fixtures stamp every invocation 2026-10-19 and ran
retention maintenance with a 30-day window, so from 2026-11-18 the
session pruned the rows the tests then read, and five writer tests
failed on every branch. The test configuration now keeps a retention
window the fixed timestamps never leave, so maintenance still runs and
prunes nothing.
@kvlonge
kvlonge enabled auto-merge November 18, 2026 00:56
@kvlonge
kvlonge added this pull request to the merge queue Nov 18, 2026
Merged via the queue into main with commit e82dfdd Nov 18, 2026
32 checks passed
@kvlonge
kvlonge deleted the test/recall-fixture-retention branch November 18, 2026 01:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant