Repository navigation
test(recall): keep writer test sessions inside the retention window - #1564
Merged
Merged
Conversation
The writer test fixtures stamp every invocation 2026-10-19 and ran retention maintenance with a 30-day window, so from 2026-11-18 the session pruned the rows the tests then read, and five writer tests failed on every branch. The test configuration now keeps a retention window the fixed timestamps never leave, so maintenance still runs and prunes nothing.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Since 00:00 UTC on 2026-11-18, five
sqlbuild-recallwriter tests fail on main and on every branch, so the "Native workspace checks" job fails for every pull request and in the merge queue. The writer test fixtures stamp invocations with a fixed date, 2026-10-19, and their sessions run retention maintenance with a 30-day window. Once that date became older than 30 days, maintenance pruned the rows the tests read back.Changes
Verification
cargo test -p sqlbuild-recall --libfails 5 of 69 tests (the session and artifact writer tests); with this change, all 69 pass.make check-cipasses on this head.