Repository navigation
fix: read Python node fingerprints from the preserved loader schema - #1560
Merged
Merged
Conversation
The preserved-target node results check now expands loader_schema with the effective vars and applies the same usability test as the runtime location: non-empty, not preserve, and no context placeholder. A target whose loader_schema resolves to nothing usable is refused before the build instead of writing results to the wrong schema.
…lanning Under a preserved target schema, Python nodes record their results and fingerprints in the loader schema, which planning never read, so every plan showed loaders, tasks and assets as new. Planning now passes the node results location into the warehouse snapshot, which reads that schema's fingerprints table without listing its other relations.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Under a target with
schema = "preserve", Python nodes keep their results and identity fingerprints inloader_schema. Two paths disagreed with that:loader_schema. A value that resolves to empty, or only to a model-context placeholder, passed the check and the build then fell back to the adapter's default location.Changes
loader_schemawith the effective vars and uses the same usability test as the runtime location (non-empty, notpreserve, no context placeholder).Verification
test_node_result_location.py: a task under a preserved schema, a loader schema var that resolves to empty, a loader schema that resolves only inside a model, and plans that read a task's fingerprint from the loader schema (whole project and the task alone) or from a named target schema. The refusal and plan cases failed before their fix.make check-cipasses on this head.