Repository navigation
fix!: keep Python node results in one location per target - #1551
Merged
Merged
Conversation
Loaders, tasks, assets and checks now write their results and loader fingerprints to one location for every target: the target's schema, the target's loader_schema when the schema is preserve, or the adapter's default schema when the target schema is unset or resolved per model. Scheduled loaders and build-time checks used the adapter default before, so adapters without one, such as Snowflake, skipped those writes. Compile stops with S105 when a preserve target without a loader_schema has Python nodes. For one release, a node whose result is missing from the new location is read from the adapter's default location instead.
Under a preserve target, also read a node's result from the schema named preserve that earlier releases wrote to, after the adapter default. The location for `sqb load`, build-time checks and `sqb check` now comes from the target settings, so each runtime reads and writes the same place.
…r result writes sqb load now takes its node-result location from the CLI-var-aware loader defaults, as build does, so a schema set with --vars is read from the same place both commands write. Build and ingress loaders write their results through one load operation.
kvlonge
disabled auto-merge
November 17, 2026 13:48
kvlonge
enabled auto-merge
November 17, 2026 13:55
github-merge-queue
Bot
removed this pull request from the merge queue due to failed status checks
Nov 17, 2026
A preserve target with a loader now needs loader_schema (S105), so the managed-source load cases set one. The source still lands in its own schema.
BREAKING CHANGE: a preserve target with Python loaders, tasks, assets or checks now needs loader_schema, which is where their results are kept. Without it, compile fails with S105, which says to set targets.<name>.loader_schema.
github-merge-queue
Bot
removed this pull request from the merge queue due to a conflict with the base branch
Nov 17, 2026
kvlonge
enabled auto-merge
November 17, 2026 16:23
kvlonge
disabled auto-merge
November 17, 2026 16:25
github-merge-queue
Bot
removed this pull request from the merge queue due to a conflict with the base branch
Nov 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Python node results landed in different places by path. Under
schema = "preserve"they went to a schema namedpreserve. Scheduled loaders (sqb build,sqb load) and build-time checks used the adapter's default schema while tasks read the target's, soctx.result_ofcould miss. On Snowflake, which has no default schema, scheduled loaders saved no results or fingerprints.Changes
Loader, task, asset and check results, and loader fingerprints, go to one place per target:
schemapreserveloader_schema${CTX:...}A
preservedatabase uses the adapter's default database.S105: compile stops when apreservetarget with loaders, tasks, assets or checks has noloader_schema.preserve, thepreserveschema. Writes go only to the new location.sqb checkreads qualify unqualified names into this location, as build tasks do.(new)until its next build.loader_schemais needed.loaders/loader_results, a task reading two loaders.Verification
preserveschema,preservedatabase and--varsschema: two builds keep loader, task and check results in one schema;sqb loadreads a loader result there.loader_schema.main, then amartbuild of one loader: the task reads both. Fails without fallback.BREAKING CHANGE: a
preservetarget with Python loaders, tasks, assets or checks now needsloader_schema. Without it, compile fails with S105, which says to settargets.<name>.loader_schema.