Repository navigation
refactor: move the execution history store into sqlbuild-python-front - #1543
Merged
Merged
Conversation
The execution history store (its SQLite and PostgreSQL backends, appends, statements, conversions and Python functions) and the resource costs table move from sqlbuild-python into sqlbuild-python-front, the layer fensu already assigns them. Nothing in a lower crate imports them, so the cost report can follow later without reaching back into sqlbuild-python. Old paths are deleted and callers updated; there are no re-exports. The review command changes only its imports. main/ entries hold the bodies they used to forward to. The resource costs table stays an XSB072/XSB073 edge as it was under native_host. The sqlbuild-python cap drops to its new size, and the moved files' budgets are re-keyed with unchanged totals.
kvlonge
disabled auto-merge
November 17, 2026 08:59
…tion-history # Conflicts: # crates/sqlbuild-python/src/bindings/_helpers/record_behaviours/constants.rs # fensu.toml
kvlonge
enabled auto-merge
November 17, 2026 09:45
kvlonge
added a commit
that referenced
this pull request
Nov 17, 2026
…ject tree Moves the execution history store and the resource cost state from the bindings crate into sqlbuild-python-front, as the slice did. The tree never changed the execution history files, so the slice's versions carry over whole; the tree's one resource-cost-state change was an import that the move already covers. Validation: cargo check --workspace --all-targets passes with no warnings and the layout matches the slice. Nothing is built or tested yet. fensu reports 349 faults, unchanged from the previous slice.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
sqlbuild-pythonis still over the crate size limit. The execution history store and the resource costs table belong to the front layer, and the cost report can only follow them out once they have moved.Changes
sqlbuild-python-frontasexecution_history. The resource costs table moves there asresource_costs. Callers use the new paths; there are no re-exports.sqlbuild-python: the execution history registration. The review command changes only fouruselines. The cost report, record behaviours and CLI registration change only their paths.main/entries hold the bodies they used to forward to.sqlbuild-pythoncap drops from 54,943 to 52,134 code lines. The resource costs table stays an XSB072/XSB073 edge, as it was undernative_host. XSB072/XSB073 budgets are re-keyed with unchanged totals.[dupes]entries cover clusters main already had whose members moved.Code lines across the
sqlbuild-python*crates: +207 in total (use+122,main/entries +46,mod+15, other item code +24).No DuckShop case: this is a behaviour-neutral Rust move with no new project shape, value or lifecycle.
Verification
_nativesurface is identical to main's build.sqlbuild-python(cargo build --profile fast, warm, 3 alternating runs, medians): 22.02→21.92 s wall, 42.0→40.8 s CPU, unchanged.make check-cipassed.make test: 12,312 passed; the 4 failures are publication tests that need Docker, as on main.