Repository navigation
refactor: move the output layer of the Python bindings into sqlbuild-python-output - #1541
Merged
Merged
Conversation
…python-output sqlbuild-python is still over the crate size limit. The output layer (build progress reporting, build result output and its documents, output capture and invocation records, cost telemetry, compute log storage and the Recall session and its stores) moves into a new crate above sqlbuild-python-planner and beside sqlbuild-python-compile. The Recall query command and its rendering stay in sqlbuild-python with the other commands, as do event exporting and the cost report, which reach code that stays there. Each moved area's registration stays too. Old paths are deleted and callers updated; there are no re-exports. main/ entries hold the bodies they used to forward to. The compute log storage registers its own class, so its area has an entry, and the Recall session takes the release version from its sqlbuild-python callers, since CARGO_PKG_VERSION is the fixed workspace version outside that crate. The sqlbuild-python cap drops to its new size, XSB072/XSB073 budgets are re-keyed with unchanged totals, and the native field fallback list follows the moved files.
kvlonge
enabled auto-merge
November 17, 2026 07:42
kvlonge
disabled auto-merge
November 17, 2026 07:48
kvlonge
added a commit
that referenced
this pull request
Nov 17, 2026
Moves the output layer from the bindings crate into the new sqlbuild-python-output crate, as the slice did, keeping the large-project tree's behaviour. The tree's registration bodies match the slice's base, so the slice's registrations carry over unchanged; main's statement-report and setup-context imports, which the tree does not have, are not carried over. Validation: cargo check --workspace --all-targets passes with no warnings, the layout matches the slice, and every line the tree added to a moved file is still present. Nothing is built or tested yet. fensu reports 349 faults, unchanged from the previous slice.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
sqlbuild-pythonis still over the crate size limit. This slice moves the output layer into its own crate.Changes
sqlbuild-python-output, abovesqlbuild-python-plannerand besidesqlbuild-python-compile(neither depends on the other). It holds build progress, result output and documents, output capture, cost telemetry, compute log storage and the Recall session and stores. Callers use the new paths; no re-exports.sqlbuild-python: each area's registration, the Recall query command and its rendering (commands layer), event exporting, and the cost report. The last two reach code that stays.main/entries hold the bodies they forwarded to. Compute log storage registers its own class, so its area has an entry.sqlbuild-pythoncap drops from 66,768 to 54,943 code lines. XSB072/XSB073 budgets are re-keyed with unchanged totals.[dupes]entries cover clusters main already had whose members moved. The native field fallback list follows the moved files.Code lines across the
sqlbuild-python*crates: +685 in total (main/entries +902,use+405,mod+85, other item code -707).No DuckShop case: this is a behaviour-neutral Rust move with no new project shape, value or lifecycle.
Verification
_nativesurface is identical to main's build.sqlbuild-python(cargo build --profile fast, warm, 3 alternating runs, medians): 22.87→22.56 s wall, 42.3→44.1 s CPU, unchanged.make check-cipassed.make test: 12,312 passed; the 4 failures are publication tests that need Docker, as on main.