Repository navigation
ci: skip the native builds when refreshing release lockfiles - #1540
Merged
Merged
Conversation
The lockfile refresh step synced every package, which compiled sqlbuild and sqlbuild-cli (about 15 minutes) on each regeneration of the release pull request before its checks could start. Skip installing those two packages, as the Verify jobs already do; the lock checks are unchanged.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Each time Release Please regenerates the release pull request, the "Refresh release lockfiles" step runs
uv sync --locked --all-groups --all-extras. That sync builtsqlbuildandsqlbuild-clifrom source, compiling both native packages. In run 44025881619 it took 14m32s ("Prepared 245 packages in 14m 32s"), and the release PR's checks and distribution build cannot start until it finishes.Changes
--no-install-package sqlbuild --no-install-package sqlbuild-cli, the same flags the Verify test jobs already use.--lockedstill fails on an inconsistent lock,cargo metadata --lockedanduv lockare unchanged, and the release distributions build still compiles both packages.Verification
uv sync --locked ... --python 3.12installs 243 packages without building either native package (under 1 s from a warm cache). Without the flags it started the native build.make check-ci, because this PR only changes one workflow file. CI runs the static checks.DuckShop: not applicable; this only changes the release workflow.